1963552 - Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Sarah Clements [:sclements]]

We'll want to add a visual for horizontal and vertical pinned tabs but this will only appear once a user starts dragging a tab per the spec and only if they don't already have pinned tabs.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1963552 - Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=#sidebar-reviewers,#tabbrowser-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a8f62522e0a8
https://hg.mozilla.org/integration/autoland/rev/2d9679453d61
Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=sidebar-reviewers,tabbrowser-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c49b80ac976
https://hg.mozilla.org/integration/autoland/rev/151d06f5e650
Revert "Bug 1963552 - Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=sidebar-reviewers,tabbrowser-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,dao" for causing bc failures @browser_tabReorder_vertical.js.

Comment 4

[agoloman]

Backed out for causing multiple bc failures.

• Backout link
• Push with failures
• Failure Log @browser_tabReorder_vertical.js
• Failure Log @browser_multiselect_tabs_copy_through_drag_and_drop.js
• Failure Log @browser_startup_images.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8f88dad6c25a
https://hg.mozilla.org/integration/autoland/rev/d594cb9cccfb
Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=sidebar-reviewers,tabbrowser-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8d04e57dbf48
https://hg.mozilla.org/integration/autoland/rev/13bd75dde7c8
Revert "Bug 1963552 - Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=sidebar-reviewers,tabbrowser-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,dao" for causing failures complaining about object XULElement.

Comment 7

[Atila Butkovits]

Backed out for causing failures complaining about object XULElement.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/13bd75dde7c87e6b6f9d4f36ac6361cfa3772b21

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VtwBuzEWThWSqnMMpPJTtA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d594cb9cccfbc6e083a83867f727a96dc7a0f59b

Failure log: https://treeherder.mozilla.org/logviewer?job_id=518799925&repo=autoland&lineNumber=29234

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6234c06055b1
https://hg.mozilla.org/integration/autoland/rev/b9dd6650484e
Add interaction cue in vertical and horizontal tabstrips to indicate its a pinnable area r=sidebar-reviewers,tabbrowser-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b9dd6650484e