Closed Bug 1967129 Opened 3 months ago Closed 2 months ago

Perma /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false | single tracking bug

Categories

(Core :: DOM: Core & HTML, defect, P5)

defect
Points:
1

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox-esr140 --- wontfix
firefox138 --- unaffected
firefox139 --- unaffected
firefox140 --- wontfix
firefox141 --- wontfix
firefox142 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: whimboo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [webdriver:m17][genai])

Attachments

(1 file)

Filed by: agoloman [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=508924540&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/BEZXZsovSom98vJVHax8QA/runs/0/artifacts/public/logs/live_backing.log


[task 2025-05-18T12:01:52.257Z] 12:01:52     INFO - TEST-START | /html/user-activation/activation-trigger-mouse-right.html
[task 2025-05-18T12:01:52.276Z] 12:01:52     INFO - Closing window a77df9ff-ab88-40a1-96a1-b4e50339e6bd
[task 2025-05-18T12:01:52.829Z] 12:01:52     INFO - {'actions': [{'type': 'none', 'actions': [{'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}, {'type': 'pause', 'duration': 16}], 'id': '0'}, {'type': 'pointer', 'actions': [{'type': 'pointerMove', 'x': 0, 'y': 0, 'origin': {'element-6066-11e4-a52e-4f735466cecf': '6fa3c2f7-4e85-45f3-a7a5-9f4a897e3c6a'}}, {'type': 'pointerDown', 'button': 2}, {'type': 'pointerUp', 'button': 2}], 'parameters': {'pointerType': 'mouse'}, 'id': '1'}]}
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-TIMEOUT | /html/editing/dnd/images/024.html | Dropping image on vertical object scrollbar - Test timed out
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-TIMEOUT | /html/editing/dnd/platform/pointerdown-add-overflow-hidden.html | dragstart should still fire when the dragged element gets overflow:hidden in its pointerdown - Test timed out
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-TIMEOUT | /html/infrastructure/urls/base-url/document-base-url-changes-about-srcdoc-2.https.html | wrapper promise test for timeout. - Test timed out
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-PASS | /html/infrastructure/urls/terminology-0/nontraditional-about-srcdoc.html | about:srcdoc with document.open() is treated like a normal about:srcdoc document 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-PASS | /html/infrastructure/urls/terminology-0/nontraditional-about-srcdoc.html | about:srcdoc navigated via a `javascript:` URL is treated like a normal about:srcdoc document 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-FAIL | /html/infrastructure/urls/terminology-0/nontraditional-about-srcdoc.html | about:srcdoc with URL changed by history.replaceState() is treated like a normal about:srcdoc document - promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-NOTRUN | /html/interaction/focus/processing-model/legend-focusable.html | legend focusable 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-PASS | /html/user-activation/activation-trigger-keyboard-enter.html | Activation through ENTER keyboard event 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-PASS | /html/user-activation/activation-trigger-keyboard-escape.html | Activation through ESCAPE keyboard event 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-PASS | /html/user-activation/activation-trigger-mouse-left.html | Activation through left-click mouse event 
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - TEST-UNEXPECTED-FAIL | /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false
[task 2025-05-18T12:01:52.960Z] 12:01:52     INFO - runTests/<@http://web-platform.test:8000/html/user-activation/activation-trigger-mouse-right.html:39:20
[task 2025-05-18T12:01:53.037Z] 12:01:53     INFO - TEST-OK | /html/user-activation/activation-trigger-mouse-right.html | took 781ms
Flags: needinfo?(edilee)
Keywords: regression
Regressed by: 1966483

Set release status flags based on info from the regressing bug 1966483

bug 1966483 probably should only look for primary click so ignore right click

Blocks: 1943389
Flags: needinfo?(edilee)
Whiteboard: [collect_confirm_failure] → [collect_confirm_failure][genai]
Summary: Perma [tier 2] /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false → Perma [tier 2] /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false | single tracking bug

was taking a look at handling only primary button click and maybe it wasn't actually bug 1966483 regressing? artifact bisect suggests it might be bug 1965183 but then bug 1966879 switched to expect fail?

See Also: → 1965183, 1966879

(In reply to Ed Lee :Mardak from comment #4)

was taking a look at handling only primary button click and maybe it wasn't actually bug 1966483 regressing? artifact bisect suggests it might be bug 1965183 but then bug 1966879 switched to expect fail?

Olli, can you please take a look?

Flags: needinfo?(smaug)
See Also: → 1968047

Set release status flags based on info from the regressing bug 1966483

Whiteboard: [collect_confirm_failure][genai] → [genai]

(I don't see recent failures)

Flags: needinfo?(smaug)

The tests in this file were marked as intermittently failing in the wpt metadata and as such are no longer reported as failure. So you would have to remove the ini file.

Flags: needinfo?(smaug)

So this is an issue on MacOS with the test. Removing the metadata I can constantly reproduce the issue. Running in verify mode causes the test to fail all the time. When I comment out setting the microtasks to level 0 at this location for Marionette the test is starting to pass again.

 0:36.49 INFO | `Activation through right-click mouse event` | FAIL    | `assert_true: mousedown event should result in activation expected true got false` |

Here it fails the consumeTransientActivation call with TypeError: Fullscreen request denied.

Given that it also fails without verify mode it should probably not only be a tier2.

I've as well pushed a try build to see if it is failing permanently as well in CI:
https://treeherder.mozilla.org/jobs?repo=try&revision=c2cb926989cee677a2fda7c38224aede518b47e8

Olli, it would be good if you could take a look please. Thanks.

Summary: Perma [tier 2] /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false | single tracking bug → Perma /html/user-activation/activation-trigger-mouse-right.html | Activation through right-click mouse event - assert_true: mousedown event should result in activation expected true got false | single tracking bug

Note that it also works when I change the test to actually use a left button click. Then fullscreen is entered. So there might be some negative effect of microtask=0 and clicking the right button.

So the test shouldn't have passed ever. full-screen-api.mouse-event-allow-left-button-only defaults to false.
It did pass because microtask handling was broken and the relevant code path run outside event dispatch.

If we want to pass the test, enabling the pref in .ini should work.
But I'm not sure if we want that, since it is not the behavior we ship to users.

(In reply to Olli Pettay [:smaug][bugs@pettay.fi] from comment #11)

So the test shouldn't have passed ever. full-screen-api.mouse-event-allow-left-button-only defaults to false.

I assume you meant to say true, because that's the default for this preference.

If we want to pass the test, enabling the pref in .ini should work.
But I'm not sure if we want that, since it is not the behavior we ship to users.

I would agree so. It might be good to pass the test, but that would mean that a spec discussion is needed and all browser vendors agree to the same behavior - which is unlikely to happen soon.

Note that a wpt downstream sync already updated the expectation:
https://hg-edge.mozilla.org/mozilla-central/diff/f9ad94cff87841302b2261c4605bf885c486f1ac/testing/web-platform/meta/html/user-activation/activation-trigger-mouse-right.html.ini

But we probably should get the multiple status removed for macOS. I can provide a patch for that.

Flags: needinfo?(smaug)
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 1
Whiteboard: [genai] → [webdriver:m17][genai]
Pushed by hskupin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f9d211b8c5e5 https://hg.mozilla.org/integration/autoland/rev/84c9c12e5270 [wpt] Update expectations on macOS for /html/user-activation/activation-trigger-mouse-right.html. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch

The patch landed in nightly and beta is affected.
:whimboo, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(hskupin)

I don't think that we have to uplift given that it is just this test which is affected and we only sync with upstream wpt on mozilla-central, and also no failures can be seen.

Flags: needinfo?(hskupin)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: