Closed Bug 1968047 Opened 1 year ago Closed 1 year ago

link preview opens in unexpected scenarios

Categories

(Core :: Machine Learning: General, defect)

Product:
Core
Component:
Machine Learning: General
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
140 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox138 --- unaffected
firefox139 --- unaffected
firefox140 + verified

People

(Reporter: soeren.hentzschel, Assigned: Mardak)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [genai])

Attachments

(1 external file)

Since a few days, the link preview opens in unexpected situations:

  1. After right clicking on a link without any further action. It always open with the text "We can't preview this link".
  2. After navigation with the keyboard shortcut shift + tabulator.

I know that you added the option to activate the link preview with only the shift key. But in the two scenarios just described, this is definitely not an expected behavior, but on the contrary it is very annoying.

i started looking into only triggering on primary button for bug 1967129 which might have been misassociated to bug 1966483. shift from bug 1962297 is much more likely to trigger when typing that we tried to workaround some instances with bug 1967131. i'm thinking maybe we ignore the hovered link after some time where mouse happens to be over a link then user hits a keyboard shortcut or begins typing requiring shift

Assignee: nobody → edilee
Blocks: 1943389
Severity: -- → S2
Keywords: regressionwindow-wanted
Regressed by: 1966483, 1962297
See Also: → 1967129, 1967131
Whiteboard: [genai]

Only trigger long click with primary button. Ignore overlink after a delay and single page app links.

Pushed by elee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d1fac5599de link preview opens in unexpected scenarios r=txia,firefox-ai-ml-reviewers

https://hg.mozilla.org/mozilla-central/rev/0d1fac5599de

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox140: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 140 Branch
QA Whiteboard: [qa-triage-done-c141/b140][qa-ver-needed-c141/b140]
Flags: qe-verify+
QA Contact: cgeorgiu
See Also: → 1969404

Hi Sören Hentzschel! Are you still able to reproduce this problem in Beta 140.0b3? I haven’t been able to reproduce the issue described in comment 0.

Could you please take a look?

Flags: needinfo?(soeren.hentzschel)

Hi,

case 1 (right click) is fixed, case 2 (shift + tab) is not fixed.

Tested in Firefox 140.0b4 and Firefox Nightly 141.0a1 (2025-06-02) on macOS 15.5.

Flags: needinfo?(soeren.hentzschel)
See Also: → 1969461

Thanks, Sören Hentzschel, for testing! Case 2 was fixed in bug 1969461 in the meantime.

Given this, I’m closing this as verified fixed, per comment 6.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c141/b140][qa-ver-needed-c141/b140] → [qa-triage-done-c141/b140][qa-ver-done-c141/b140]
status-firefox140: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: