1967131 - Using Shift while typing unexpectly triggers Link Preview on Windows

Status: VERIFIED FIXED

(Core :: Machine Learning: General, defect)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

1. Open Bugzilla
2. Click the comment box
3. Put the mouse cursor over a link
4. Type anything including capital letters

Expected: No interrupt while typing
Actual: Typing a capital letter with Shift triggers link preview

This further affects Korean input as opening Link Preview breaks the ongoing composition. (Trying to type "계" becomes "ㄱㅖ" for example.)

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1962297

:Mardak, since you are the author of the regressor, bug 1962297, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Ed Lee :Mardak]

yeah, i've been accidentally triggering when typing in urls that need shift-;, e.g., about:config

you can turn off the shortcut from about:preferences#general-link-preview since today's 20250518091432 (or just go to about:config browser.ml.linkPreview.shift)

i wonder if ignoring keyboard shortcuts if there's been recent typing (and not just keyboard modifiers) would avoid accidentally triggering?

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1967131 - Using Shift while typing unexpectly triggers Link Preview on Windows r=txia!

Track recent typing and ignore shortcut if within pref controlled 1000ms.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b482049a210
Using Shift while typing unexpectly triggers Link Preview on Windows r=txia,firefox-ai-ml-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2b482049a210

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 140.0a1 (2025-05-18). Using the Shift key while typing inside a text area while the mouse cursor is hovering over a link will trigger link preview.
Unfortunately, I can still reproduce this issue on Windows 10x64 with 140.0b2 if I hover a link and then press the Shift key. This only occurs if I select the text field, then quickly press the Shift key after hovering over the link. However, if I click inside the text field, hover over the link, wait a moment, and then press Shift, the link preview doesn't appear. Is this the expected behavior, or should we open a new issue? Thank you!

Comment 7

[Ed Lee :Mardak]

that matches up with the heuristics of detecting typing while still allowing previews on new links. we can still file a new issue to track the cases that it still triggers: quickly pressing shift after hovering before typing

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Ed Lee :Mardak from comment #7)

that matches up with the heuristics of detecting typing while still allowing previews on new links. we can still file a new issue to track the cases that it still triggers: quickly pressing shift after hovering before typing

Thank you! I have filed bug 1969404 for the remaining issue. Closing this as verified. Selecting a text field and pressing the Shift key after some time will no longer open Link Preview on Windows 10x64, macOS 12, and Ubuntu 24 with Firefox 140.0b2.