1968073 - FTUE - Launch Account Hub on startup

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task, P1)

Description

[Vineet Deo]

The account hub is currently configured to only launch for secondary account creation. This task is for showing account hub on start up.

Comment 1

[Vineet Deo]

Attachment: WIP: Bug 1968073 - Account Hub Launch on startup.

How to Test

• Open Thunderbird with a fresh profile
• The account hub dialog should be the first thing you see

Comment 2

[Vineet Deo]

Account hub needs to be shown if there aren't the following accounts setup:
Email: Local folder
Address Book: Local, CardDav
Calendar: Local, LDAP, CalDav

This will affect lots of tests, so the tests need to be updated.

Comment 3

[Martin Giger [:freaktechnik]]

• We should treat it as not needing account hub if there is any account that is not hidden (so there is an account listed in the account manager) and is valid, and not just base it around local folders. The other conditions with address books and calendars make sense, though I'm not sure we should explicitly filter for types.
• Tests shouldn't need updating if we still respect the pref the old account setup set and that lots of test manifests set: "mail.provider.suppress_dialog_on_startup"
• We want to keep most of the old startup logic in place generally (for example the local folder creation in verifyExistingAccounts probably)
• Implementation notes: we'll create a new module that exports a function with a boolean result if we want to trigger account hub and all new code bases the decisions around that. The module might not actually implement any logic to start with and we can enhance it with the requirements from above as follow-ups, until it is ready to actually be used.

Comment 4

[Martin Giger [:freaktechnik]]

Oh, a note on calendars, they need to be enabled calendars, since every profile has a calendar by default, it's just disabled. -> we should probably just use https://searchfox.org/comm-central/rev/35165fe236542d31671befb680077499b46eb303/calendar/base/modules/calCalendarDeactivator.sys.mjs#61

Comment 5

[Alex Schmitz]

Attachment: Bug 1968073 - Open account hub on first run. r=#thunderbird-front-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f269f937f861
Open account hub on first run. r=freaktechnik

Comment 7

[Martin Giger [:freaktechnik]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Changed the FTUE experience thoroughly. Allows setup of EWS accounts as initial account.
[Suggested wording]: Using new account hub to set up initial mail account
[Links (documentation, blog post, etc)]: