1968118 - Convert settings related to Permissions & Data page to config-based settings

Status: ASSIGNED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Permissions & Data page will need to be converted to the config-based settings structure. If settings share a similar pattern to the current design then it may make sense to convert them to the SRD 2025's new design. If they differ significantly, it may be necessary to create a custom component for the old version, and a new version; ideally this can still share most of the business logic to avoid regressions later.

This page will have the following sections which may be good candidates for individual bugs to work on:

• Website Permissions
• Content
• Firefox data collection
• Website advertising

Comment 1

[Hanna Jones [:hjones]]

Once all the blocking conversions are complete this bug will cover the work involved in reorganizing the relevant sections to create the finalized Permissions and data page as specified in Figma here: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6396-15387&m=dev

As part of this work we should also make sure all the strings and illustrations match the design.

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1968118, part 1 - Migrate security and privacy config-based code to a new module - r=hjones!

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1968118, part 2 - Import services and modules into the privacy settings module - r=hjones!

It actually works without this change. However, shadowing the imports
from preferences.js is probably a little nicer than just adding a
mountain of globals on import, and gives a chance to not import those
things to preferences.js later.

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1968118, part 3 - Implement the privacy and security SRD as a pane - r=hjones!

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1968118, part 4 - Add a connection and software security subpane - r=hjones!

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1968118, part 5 - Test cleanups for Privacy and security SRD migration to a pane - r=emz!

Notable here: We are not migrating the cookie banner handling UI, so I
have removed it earlier in the stack. I'm removing the test in its
entirety.

Comment 7

[Hanna Jones [:hjones]]

Attachment: Bug 1968118 - Create new Permissions and data pane r=#recomp-reviewers

Comment 8

[Hanna Jones [:hjones]]

Attachment: Bug 1968118 - Refactor permissions dialog helpers r=#recomp-reviewers

Comment 9

[Phabricator Automation]

Comment on attachment 9565991 [details]
Bug 1968118, part 1 - Migrate security and privacy config-based code to a new module - r=hjones!

Revision D292198 was moved to bug 1968112. Setting attachment 9565991 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9565992 [details]
Bug 1968118, part 2 - Import services and modules into the privacy settings module - r=hjones!

Revision D292199 was moved to bug 1968112. Setting attachment 9565992 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9565993 [details]
Bug 1968118, part 3 - Implement the privacy and security SRD as a pane - r=hjones!

Revision D292200 was moved to bug 1968112. Setting attachment 9565993 [details] to obsolete.

Comment 12

[Phabricator Automation]

Comment on attachment 9565994 [details]
Bug 1968118, part 4 - Add a connection and software security subpane - r=hjones!

Revision D292201 was moved to bug 1968112. Setting attachment 9565994 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9565995 [details]
Bug 1968118, part 5 - Test cleanups for Privacy and security SRD migration to a pane - r=emz!

Revision D292202 was moved to bug 1968112. Setting attachment 9565995 [details] to obsolete.