Closed Bug 1968118 Opened 1 year ago Closed 3 months ago

Convert settings related to Permissions & Data page to config-based settings

Categories

(Firefox :: Settings UI, task)

Product:
Firefox
Component:
Settings UI
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: mstriemer, Assigned: hjones)

References

(Depends on 3 open bugs, Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(2 files, 5 obsolete files)

Bug 1968118 - Create new Permissions and data pane r=#recomp-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 1968118 - Refactor permissions dialog helpers r=#recomp-reviewers
48 bytes, text/x-phabricator-request
Details | Review

The Permissions & Data page will need to be converted to the config-based settings structure. If settings share a similar pattern to the current design then it may make sense to convert them to the SRD 2025's new design. If they differ significantly, it may be necessary to create a custom component for the old version, and a new version; ideally this can still share most of the business logic to avoid regressions later.

This page will have the following sections which may be good candidates for individual bugs to work on:

  • Website Permissions
  • Content
  • Firefox data collection
  • Website advertising
Depends on: 1972371
Depends on: 1972373
Depends on: 1972374
Depends on: 1999769

Once all the blocking conversions are complete this bug will cover the work involved in reorganizing the relevant sections to create the finalized Permissions and data page as specified in Figma here: https://www.figma.com/design/2b02v18AppIpsTceWac2T3/Settings-Desktop?node-id=6396-15387&m=dev

As part of this work we should also make sure all the strings and illustrations match the design.

Assignee: nobody → bvandersloot
Status: NEW → ASSIGNED

It actually works without this change. However, shadowing the imports
from preferences.js is probably a little nicer than just adding a
mountain of globals on import, and gives a chance to not import those
things to preferences.js later.

Notable here: We are not migrating the cookie banner handling UI, so I
have removed it earlier in the stack. I'm removing the test in its
entirety.

Comment on attachment 9565991 [details]
Bug 1968118, part 1 - Migrate security and privacy config-based code to a new module - r=hjones!

Revision D292198 was moved to bug 1968112. Setting attachment 9565991 [details] to obsolete.

Attachment #9565991 - Attachment is obsolete: true

Comment on attachment 9565992 [details]
Bug 1968118, part 2 - Import services and modules into the privacy settings module - r=hjones!

Revision D292199 was moved to bug 1968112. Setting attachment 9565992 [details] to obsolete.

Attachment #9565992 - Attachment is obsolete: true

Comment on attachment 9565993 [details]
Bug 1968118, part 3 - Implement the privacy and security SRD as a pane - r=hjones!

Revision D292200 was moved to bug 1968112. Setting attachment 9565993 [details] to obsolete.

Attachment #9565993 - Attachment is obsolete: true

Comment on attachment 9565994 [details]
Bug 1968118, part 4 - Add a connection and software security subpane - r=hjones!

Revision D292201 was moved to bug 1968112. Setting attachment 9565994 [details] to obsolete.

Attachment #9565994 - Attachment is obsolete: true

Comment on attachment 9565995 [details]
Bug 1968118, part 5 - Test cleanups for Privacy and security SRD migration to a pane - r=emz!

Revision D292202 was moved to bug 1968112. Setting attachment 9565995 [details] to obsolete.

Attachment #9565995 - Attachment is obsolete: true
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1436c9348ba7 https://hg.mozilla.org/integration/autoland/rev/a77098a90cc4 Revert "Bug 1968118 - Refactor permissions dialog helpers r=mstriemer" for causing bc failures @browser_backup_warning_banner.js.

Backed out for causing bc failures @browser_backup_warning_banner.js.

Flags: needinfo?(bvandersloot)
Assignee: bvandersloot → hjones
Flags: needinfo?(bvandersloot) → needinfo?(hjones)
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9ea33ecd0fe7 https://hg.mozilla.org/integration/autoland/rev/8f81113ae4b2 Revert "Bug 1968118 - Refactor permissions dialog helpers r=mstriemer" for causing build bustages.

Relanded the changesets because another changeset was the culprit.

Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bf13adc88258 https://hg.mozilla.org/integration/autoland/rev/7a258d4ee6e3 Revert "Bug 1968118 - Refactor permissions dialog helpers r=mstriemer" for causing bc failures @ browser_backup_warning_banner

Backed out for causing bc failures

Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/66a96678d059 https://hg.mozilla.org/integration/autoland/rev/315b3b923a67 Revert "Bug 1968118 - Refactor permissions dialog helpers r=mstriemer" for causing bc failures at UsageTelemetry_interaction

Backed out for causing bc failures at UsageTelemetry_interaction
Backout Link
Push with failures
Failure Log
TV
Failure line TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_UsageTelemetry_interaction.js | toolbarButtons - Uncaught exception in test - TypeError: can't access property "testGetValue", Glean.browserUiInteraction[source] is undefined

https://hg.mozilla.org/mozilla-central/rev/ae4b3d982a2a
https://hg.mozilla.org/mozilla-central/rev/a80aae0b2be0

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Depends on: 2037773
Depends on: 2037848
Depends on: 2037912
Depends on: 2038263
Depends on: 2038190
Depends on: 2038206
Flags: needinfo?(hjones)
QA Whiteboard: [qa-triage-done-c153/b152]
See Also: → 2042309
Depends on: 2043303
Depends on: 2044635
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: