1999769 - Convert Data Collection and Use to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The Firefox Data Collection and Use section on the Privacy & Security settings page should be converted to the config-based settings system.

• Group with description and link
  • The description links to the privacy policy which has custom link text. We may need to slot this message in somehow
• Message bar: These settings apply to every Firefox profile on this device
• Message bar on disabling: [...] past data will be deleted within 30 days
• Send technical and interaction data to Mozilla
  • Allow personalized extension recommendations
  • Install and run studies
    • View Firefox studies
• Send daily usage ping to Mozilla
• Automatically send crash reports

Comment 1

[Mark Kennedy [:mark]]

Attachment: Bug 1999769 - Add typing for Preferences paneshown event r=#reusable-components-reviewers-rotation

Also requires that our CustomEvent type be generic to support a custom type for details property

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 1999769 - Convert Data Collection section to config-based structure r=#reusable-components-reviewers-rotation

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/01ff5242c0cb
https://hg.mozilla.org/integration/autoland/rev/9088eb60798c
Convert Data Collection section to config-based structure r=fluent-reviewers,desktop-theme-reviewers,hjones,bolsson,hsohaney,beth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/25d9292b76ed
https://hg.mozilla.org/integration/autoland/rev/0cd8ac21ce9c
Revert "Bug 1999769 - Convert Data Collection section to config-based structure r=fluent-reviewers,desktop-theme-reviewers,hjones,bolsson,hsohaney,beth" for causing mochitests failures in browser_about_settings.js.

Comment 6

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_about_settings.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_about_settings.js | test_openPreferences_aboutSettings - uncaught exception - PreferenceNotAddedError: Setting "automaticallySubmitCrashesBox" was unable to find Preference "browser.crashReports.unsubmittedCheck.autoSubmit2". Did you register it with Preferences.add/addAll? at PreferenceNotAddedError@chrome://global/content/preferences/Setting.mjs:182:5

Comment 7

[Mark Kennedy [:mark]]

Thank you! Resolved this issue and will be re-landing after its approved.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70dc097cdc5d
https://hg.mozilla.org/integration/autoland/rev/3a1a599ada99
Convert Data Collection section to config-based structure r=fluent-reviewers,desktop-theme-reviewers,hjones,bolsson,hsohaney,beth

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e49c5afcefb2
https://hg.mozilla.org/integration/autoland/rev/d9707d33e6d3
Revert "Bug 1999769 - Convert Data Collection section to config-based structure r=fluent-reviewers,desktop-theme-reviewers,hjones,bolsson,hsohaney,beth" for causing bc failures @ browser_about_preferences.js DONTBUILD

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_about_preferences.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d9707d33e6d35f4f1e48f362f9fbe041b5270b62

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/normandy/test/browser/browser_about_preferences.js

Comment 11

[Mark Kennedy [:mark]]

Fixed and queued again for landing. Thank you!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/35779275ca7a
https://hg.mozilla.org/integration/autoland/rev/024fe117a904
Convert Data Collection section to config-based structure r=fluent-reviewers,desktop-theme-reviewers,hjones,bolsson,hsohaney,beth

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/024fe117a904