1972371 - Convert Website Permissions to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Hanna Jones [:hjones]]

The Website Permissions section on the Privacy & Security settings page should be converted to the config-based settings system. In this case we can make a slight visual enhancement at the same time as doing the conversion by using moz-box-group and moz-box-button to implement the UI as designed in Figma. This will involve:

• Wrapping all the settings items in a moz-box-group type="list" element
• Slotting in a moz-box-button for each type of permission
• Having the moz-box-buttons open the existing modals

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1972371 - Convert Website Permissions to config-based prefs - r=#recomp-reviewers!,emz!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dcfc64fe2d8d
https://hg.mozilla.org/integration/autoland/rev/1647e74157b3
Convert Website Permissions to config-based prefs - r=emz,fluent-reviewers,akulyk,bolsson

Comment 3

[Cristina Horotan [:chorotan]]

Backed out for causing chrome failures on test_moz_message_bar.html

Backout link

Push with failures

Failure log
Failure log bc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/94691d791e17
https://hg.mozilla.org/integration/autoland/rev/a235a7634cb5
Convert Website Permissions to config-based prefs - r=emz,fluent-reviewers,akulyk,bolsson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ab76d176aba
https://hg.mozilla.org/integration/autoland/rev/96f5d5f81332
Revert "Bug 1972371 - Convert Website Permissions to config-based prefs - r=emz,fluent-reviewers,akulyk,bolsson" for causing bc failures @ browser_search_within_preferences_1.js

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_search_within_preferences_1.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/96f5d5f813325378780fd78b834c1ba9156413c7

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_search_within_preferences_1.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a7c1df529aa
https://hg.mozilla.org/integration/autoland/rev/4b7ddcbddd88
Convert Website Permissions to config-based prefs - r=emz,fluent-reviewers,akulyk,bolsson

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4b7ddcbddd88