1969012 - Additional telemetry for link previews: labs options and about pages

Status: VERIFIED FIXED

(Core :: Machine Learning, enhancement)

Description

[Vanessa Sabino]

1. Record additional metrics to determine user settings (they should always be populated, independently of the user changing the settings on that session):
   genai.linkpreview.ai_optin
   genai.linkpreview.key_points
   genai.linkpreview.shortcut

2. Add an extra key on option on labs_checkbox event to differentiate between the checkboxes.

3. Add an extra key tab on start, fetch, generate, card_link, card_close and key_points_toggle that identifies if he user is in about:home or about:newtab.

See spreadsheet for details

Comment 1

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: we added some new link preview shortcuts, opt-in functionality for 140 experiment that we want to measure how users interact

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox140 (beta). However, the bug still isn't assigned.

:tarek, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Tim Xia]

Attachment: Bug 1969012 - Additional telemetry for link previews: labs options and about pages - r=Mardak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/99a18410c9f2
https://hg.mozilla.org/integration/autoland/rev/ed7d071d34e4
Additional telemetry for link previews: labs options and about pages - r=Mardak,firefox-ai-ml-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ece16c98bc08
https://hg.mozilla.org/integration/autoland/rev/72fb14658500
Revert "Bug 1969012 - Additional telemetry for link previews: labs options and about pages - r=Mardak,firefox-ai-ml-reviewers" for causing bc failures on browser_link_preview_telemetry.js

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_link_preview_telemetry.js

Push with failures

Failure log

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ab4a6dc6b018
https://hg.mozilla.org/integration/autoland/rev/e41a39280f3d
Additional telemetry for link previews: labs options and about pages - r=Mardak,firefox-ai-ml-reviewers

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e41a39280f3d

Comment 10

[Donal Meehan [:dmeehan]]

:txia/:Mardak could you please add a beta uplift request when you're ready.

Comment 11

[Tim Xia]

Attachment: Bug 1969012 - Additional telemetry for link previews: labs options and about pages - r=Mardak

• add telemetry "tab" field for start, cardlink, cardClose
• add labsCheckbox event for shift, shift_option, long_press, key_points, link_previews
• add _getTabContextValue to get the filepath for any about: pages
• update optin telemetry
• add metrics
• shift_alt and long_press name normalization
• add key_points (boolean) to card_link
• update test to test against blank
• refactor _getTabContextValue
• add tests for new metric and prefChanged

Original Revision: https://phabricator.services.mozilla.com/D251779

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Without additional visibility provided by telemetry metrics and events in this patch, we'd have limited data to show value of features shipped for 140 experiment for Link Preview. This could contribute to missed signals about possible regressions in end-user experiences.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Trigger link preview(shift+hover url) after setting browser.ml.linkPreview.enabled to true and verify glean data
• Risk associated with taking this patch: Low. We only introduce new telemetry calls around an existing feature. No logic changes to link preview rendering.
• Explanation of risk level: Adding telemtry does not alter user-visible behavior. Automated tests validate glean data, and manual QE is straightforward.
• String changes made/needed: None
• Is Android affected?: no

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/84476b636eef
https://hg.mozilla.org/releases/mozilla-beta/rev/e3b04f5c8948

Comment 14

[Ciprian Georgiu, Desktop QA]

I've verified this issue as fixed (based on the info provided in comment 0) using Beta 140.0b6 and latest Nightly 141.0a1 under Win 11, macOS 15 and Ubuntu 24.