1969490 - Symbolicate profiles from simpleperf task

Status: RESOLVED FIXED

(Testing :: Performance, task, P2)

Description

[Kash Shampur [:kshampur] ⌚EST]

following 1969049 Using Samply and the crash symbols artifacts, symbolicate the results to be viewable with a firefox profiler

Comment 1

[Denis Palmeiro [:denispal]]

Hi Markus, could you please add the steps necessary to symbolicate a samply profile? Thanks!

Comment 2

[Markus Stange [:mstange]]

There are two options:

1. Implement a --presymbolicate option in samply and then do samply import --presymbolicate --save-only -o symbolicated-profile.json.gz --breakpad-symbol-dir /path/to/unzipped/crashreporter-symbols --breakpad-symbol-server https://symbols.mozilla.org/ perf-2.data
2. Or utilize the symbolicator-cli node script
   • samply import --no-open -o converted-but-unsymbolicated-profile.json --breakpad-symbol-dir /path/to/unzipped/crashreporter-symbols --breakpad-symbol-server https://symbols.mozilla.org/ perf-2.data
   • grab the URL that's printed by it
   • node dist/symbolicator-cli.js --input converted-but-unsymbolicated-profile.json --output symbolicated-profile.json --server <URL from samply import>
   • terminate the samply import process

The second option is a bit trickier because you also have to obtain the symbolicator-cli.js script and have a node environment, but at least it's not blocked on samply changes.

The first option is what we want in the long term anyway. I am planning to implement --presymbolicate but I can't commit to a timeline. I could also mentor that part.

Comment 3

[Abhishek Nimalan [:animalan]]

Attachment: Bug 1969490 - Symbolicate profiles in simpleperf tasks. r=#perftest-reviewers,kshampur

Comment 4

[Abhishek Nimalan [:animalan]]

Attachment: WIP: Bug 1969490 - Add mozperftest tests for simpleperf symbolication. r=#perftest-reviewers,kshampur

Comment 5

[Abhishek Nimalan [:animalan]]

Attachment: Bug 1969490 - Add mozperftest unit tests for simpleperf symbolication. r=#perftest-reviewers,kshampur

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84e47335efd1
https://hg.mozilla.org/integration/autoland/rev/0eb2bb0f5f36
Symbolicate profiles in simpleperf tasks. r=kshampur,perftest-reviewers,mozperftest-reviewers
https://github.com/mozilla-firefox/firefox/commit/b1e019ff2c6d
https://hg.mozilla.org/integration/autoland/rev/aeea9a31b2c9
Add mozperftest unit tests for simpleperf symbolication. r=kshampur,perftest-reviewers,mozperftest-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0eb2bb0f5f36
https://hg.mozilla.org/mozilla-central/rev/aeea9a31b2c9