1969767 - Embed Link - insert link fails with advanced options

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[bugzilla-mozilla]

Steps to reproduce:

https://support.mozilla.org/en-US/questions/1514728

1. Create new email.
2. Paste link string.
3. "Insert" link for string, adding advanced options (NOT adding advanced options does NOT replicate this issue - only with advanced options)

Actual results:

String remained a string, not a link

Expected results:

String should have converted to link with advanced options.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

comm-central regression window
mozilla-central regression window

Probably regressed by bug 1803044.

By the way, just clicking "Advanced Edit…" and "Cancel" is enough to show this behavior. Apparently something here now triggers this.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1969767 - Fix inserting link with advanced properties. r=#thunderbird-reviewers

This is workaround for changes in behavior of nsIHTMLEditor's insertLinkAroundSelection, apparently introduced by bug 1803044.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10739603ee34
Fix inserting link with advanced properties. r=mkmelin

Comment 4

[Corey Bryant]

Do you want to uplift this to 140 beta?

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9492170 [details]
Bug 1969767 - Fix inserting link with advanced properties. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Simple bug fix without any risk to be expected.
• User impact if declined: Creating a link from selected text does not work when advanced properties are selected as well.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: 1. Open a (HTML) compose window.

2. Type http://www.example.com.
3. Select all.
4. Insert -> Link… (Ctrl-K)
5. Advanced Edit…
6. Set an attribute and value (eg. lang and en)
7. Ok, Ok
8. Ctrl-K and Advanced Properties… again

After step 7, text should be linkified, after step 8, the set attribute should be displayed.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No side-effects to be expected.
• String changes made/needed: None.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9492170 [details]
Bug 1969767 - Fix inserting link with advanced properties. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 140.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/9f12f111408d