1975621 - Thunderbird 140 x64 Insert URL not working

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Chad Simmons]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

Insert a hyperlink using the URL insert menu.

Actual results:

Text is inserted, but the hyperlink does not appear to be active.
Text must be highlighted and the process to insert the URL performed again in order for the hyperlinked text to appear correctly.

Expected results:

Text should have been inserted and hyperlinked to the provided URL in a single operation.

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, bug 1969767 was uplifted to 140 so it should be working...

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1975621 - Fix regression from bug 1969767. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb659081638e
Fix regression from bug 1969767. r=mkmelin

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9498606 [details]
Bug 1975621 - Fix regression from bug 1969767. r=mkmelin

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Recent regression.
• User impact if declined: Simply inserting a link into an HTML mail does not work as expected.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: 1. Open a (HTML) compose window.

2. Select message body.
3. Insert -> Link… (Ctrl-K)
4. Type http://www.example.com into the second text field.
5. Ok

Verify that a clickable link is produced. Please also verify the steps from bug 1969767 comment 5 still work.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very simple change that restores the original code path for creating (not editing) a link.
• String changes made/needed: None.

Comment 6

[Corey Bryant]

Comment on attachment 9498606 [details]
Bug 1975621 - Fix regression from bug 1969767. r=mkmelin

[Triage Comment]
Approved for beta
Approved for release
Approved for esr140

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 140.0.1:
https://hg.mozilla.org/releases/comm-release/rev/d170008a572a

Comment 8

[Corey Bryant]

Vlad/Ramona, can you test this once 140.0.1 and 140.0.1esr are available?

Comment 10

[Ramona Gavrilescu]

Confirm as verified fixed on on TB 140.0.1(20250709044702) using macOS Sequoia 15.5.
Will verify it on 140.0.1esr once it's available.

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 141.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/9128248251a6

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 140.0.1:
https://hg.mozilla.org/releases/comm-release/rev/d170008a572a

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 140.0.1esr:
https://hg.mozilla.org/releases/comm-esr140/rev/c8c614aacc44e6c5ae39745417e01d6ea619f9c1

Comment 14

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirmed as verified fixed on on TB 140.0.1esr(20250709213912) using macOS Sequoia 15.5, Ubuntu 25 and Windows 11.