1970096 - Checkbox and Button outlines are barely visible in prompts and in Profile Manager

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screenshot 2025-06-03 094702.png

Found in

• 141.0a1 (2025-06-02)

Affected versions

• 141.0a1

Tested platforms

• Affected platforms: macOS 14, Windows 11, Ubuntu 22.04
• Unaffected platforms: none

Preconditions

• Have the “Always check if Nightly is your default browser” option from about:preferences enabled

Steps to reproduce

1. Launch Firefox and observe the checkbox in the “Make Nightly your primary browser?” prompt
2. [Windows/Linux only] Close the browser and open the Profile Manager
3. Observe the outline of the elements (buttons and checkboxes) in the Profile Manager

Expected result

• All elements (buttons and checkboxes) should have clearly defined, visible outlines

Actual result

• The checkbox from the setting Nightly as the default browser prompt has a barely visible outline
• [Winows/Linux] The outlines of elements (buttons and checkboxes) in the Profile manager are also barely visible

Regression range

• Potentially regressed by: bug 1968925

Additional notes

• The issue is not reproducing on macOS for the Profile Manager
• See the attached screenshot
• Please feel free to change the component accordingly

Comment 1

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screenshot 2025-06-03 105537.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1968925, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1970096 - Make windows buttonborder match threedshadow. r=#win-reviewers,#theme,#layout

Now that we're using it by default. This matches the old styling.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/44b4d69c78d2
https://hg.mozilla.org/integration/autoland/rev/3cb03c962ee1
Make windows buttonborder match threedhighlight. r=win-reviewers,gstoll

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3cb03c962ee1

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screenshot 2025-06-10 062924.png

Verified this using Firefox Nightly 1410a1 (2025-06-09), on Windows 11, macOS 14 and Ubuntu 22.04.
@emilio, on macOS and Ubuntu, the checkbox from the setting Nightly as the default browser prompt still has a barely visible outline. On Windows, the checkbox is not visible at all - please see the attached screenshot.
Additionally, only on Windows, the elements in the Profile manager now display a white outline when hovered over.
Based on the above, I am reopening this ticket.

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: Screenshot 2025-06-10 063759.png

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/537db506b9cf
https://hg.mozilla.org/integration/autoland/rev/4855e0f9defe
Revert "Bug 1970096 - Make windows buttonborder match threedhighlight. r=win-reviewers,gstoll" as requested for not addressing the issue properly.

Comment 9

[Serban Stanca [:SerbanS]]

Reverted this as requested for not addressing the issue properly.

• Backout link

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4b90f62f7c82
https://hg.mozilla.org/integration/autoland/rev/79051e9448c6
Make windows buttonborder match threedshadow. r=win-reviewers,gstoll

Comment 11

[Emilio Cobos Álvarez [:emilio]]

comment 10 should fix the issue on windows, looking at macOS and Linux now.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1970096 - Actually just use standins for those colors on macOS and Windows.

Since that provides hover feedback and more exactly preserves behavior.

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Ok, let's file a follow-up for linux if you see issues there, indicating what gtk theme are you using (for about:support). This bug will fix macOS and Windows. Thanks!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bb27c81a35fc
https://hg.mozilla.org/integration/autoland/rev/ddec1c4a428e
Actually just use standins for those colors on macOS and Windows.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cedd90388f7b
https://hg.mozilla.org/integration/autoland/rev/105ef2cf866e
Revert "Bug 1970096 - Actually just use standins for those colors on macOS and Windows." for bustages on /nsLookAndFeel.cpp

Comment 17

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on /nsLookAndFeel.cpp

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/105ef2cf866ebcc2da8db77bcd8c5781cb167eb8
Log link: https://treeherder.mozilla.org/logviewer?job_id=512408048&repo=autoland&lineNumber=96505

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/79051e9448c6

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45e1bc184258
https://hg.mozilla.org/integration/autoland/rev/1d0bc96615c2
Actually just use standins for those colors on macOS and Windows. r=win-reviewers,handyman

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1971271: S3

:emilio, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.

Comment 21

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #13)

Ok, let's file a follow-up for linux if you see issues there, indicating what gtk theme are you using (for about:support). This bug will fix macOS and Windows. Thanks!

Sure thing. Logged bug 1971549 for Linux.

Comment 22

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1d0bc96615c2

Comment 23

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox Nightly 141.0a1 (2025-06-11) on Windows 11 and macOS 14. Checkbox and Button outlines are now visible in prompts and in Profile Manager.

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1968925

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR140 when you get a chance.

Comment 26

[Emilio Cobos Álvarez [:emilio]]

I think this doesn't affect ESR since only the low-risk fix was uplfited to 140. Please double-check me tho...

Comment 27

[Ryan VanderMeulen [:RyanVM]]

Indeed, thanks for noticing that.