1968925 - After removal of GTK3 button styling, Profile Picker and other classic dialogs now have no button styling

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Dominic Hayes]

Attachment: Profile Picker with the regression

Because of the removal of GTK3 button styling in Nightly, the Profile Picker and all other Classic-era Firefox dialogs now lack proper button styling.

The logical fix here would be to give them the same styling as the non-native buttons seen in the footer of Customise Toolbar, as that is exactly what Lepton and GTKless have both done for their respective button -> non-GTK button CSS transformation mods, and would be most consistent.

Comment 1

[Dominic Hayes]

Attachment: Heavily regressed Library dialog

Comment 2

[Dominic Hayes]

Attachment: Page Information...

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Emilio, any idea here?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

What GTK theme are you using? The issue seems to be that we get the same color for a lot of stuff, which is a bit unexpected.

I agree long term it'd be good to move towards more modern styling tho.

Comment 5

[Dominic Hayes]

Breeze
Color scheme: Norway (from KDE4&5) (official KDE Pling upload)

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1968925 - Minor improvements to GTK button colors. r=stransky

Actually return the right color for Buttonface, and compute the
background for active buttons passing both the "hover" and "active"
states.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1968925 - Better themed buttons in GTK. r=stransky,#theme

This patch got a bit larger than expected mostly to deal well with
windows HCM, but the TLDR is that we introduce Button*border colors, and
deal with them in the non-native theme, rather than hard-coding them.

We also leave the previous hardcoded colors in the standin set, so that
web content doesn't change behavior, and reorder a bit the colors to be
closer together.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198e2f43c0e3
Minor improvements to GTK button colors. r=stransky

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/198e2f43c0e3

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3d50342c7eec
https://hg.mozilla.org/integration/autoland/rev/dc2493908a75
Better themed buttons in GTK. r=stransky,desktop-theme-reviewers,dao

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2000b837de52
https://hg.mozilla.org/integration/autoland/rev/5609d5ae7153
Fix windows bustage.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8d18667241a8
https://hg.mozilla.org/integration/autoland/rev/6a4046f08645
Fix a mochitest to reflect more correct stand-in colors.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/54e18af91781
https://hg.mozilla.org/integration/autoland/rev/b4887437910f
Remove unused sColorGrey30 to fix non-unified builds.

Comment 14

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/dc2493908a75
https://hg.mozilla.org/mozilla-central/rev/5609d5ae7153
https://hg.mozilla.org/mozilla-central/rev/6a4046f08645
https://hg.mozilla.org/mozilla-central/rev/b4887437910f

Comment 15

[Donal Meehan [:dmeehan]]

:emilio, what are you're thoughts on the risk of requesting uplifting for this? (Including the fix for the regressor Bug 1970096)

Comment 16

[Emilio Cobos Álvarez [:emilio]]

I think we should uplift just https://hg-edge.mozilla.org/integration/autoland/rev/198e2f43c0e3, but let the rest be.

There's also bug 1967569 interacting here, and the buttons in non-default themes look a bit uglier than expected, but not unusable...

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9491402 [details]
Bug 1968925 - Minor improvements to GTK button colors. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Mostly fixes this (still would show out-of-place borders, but that's not the worst)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 with a non-default GTK theme
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixes GTK button backgrounds.
• String changes made/needed: None
• Is Android affected?: No

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9491402 [details]
Bug 1968925 - Minor improvements to GTK button colors. r=stransky

Approved for 140.0b9

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/1b7cbf2e3c22
https://hg.mozilla.org/releases/mozilla-beta/rev/cae810e1fd6f

Comment 20

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 22 Dec-9 Jan, please ni? :mboldan]]

Attachment: style2.png

Hello! I installed Kubuntu 24.04, set the Global theme to Breeze and Colors to Norway by kdecommunity (downloaded from Get New color Schemes > System Settings)
Reproduced the issue with Firefox 140.0b8 on the above system. The buttons from Library, Page Info, and Profile Manager lack style.
However, I am not certain if the fixed builds show the correct behavior. I have attached a screenshot with fixed builds ( Firefox 140.0b9 (treeherder build from comment 19) and Firefox 141.0a1 (2025-06-12). These are tar.xz builds. Can you please confirm that this is OK, or am I missing something here? Thank you!

Comment 21

[Emilio Cobos Álvarez [:emilio]]

Yes that's the expected behavior. There are further improvements in nightly that are not upliftable.

Comment 22

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 22 Dec-9 Jan, please ni? :mboldan]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #21)

Yes that's the expected behavior. There are further improvements in nightly that are not upliftable.

Thank you! Closing this based on the above comments.