1971549 - [Ubuntu] Checkbox outlines are barely visible in prompts, sidebar and in Profile Manager

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: 12.png

Found in

• 141.0a1 (2025-06-10)

Affected versions

• 141.0a1

Tested platforms

• Affected platforms: Ubuntu 22.04

Preconditions

• Have the “Always check if Nightly is your default browser” option from about:preferences enabled

Steps to reproduce

1. Launch Firefox and observe the checkbox in the “Make Nightly your primary browser?” prompt
2. Enable the dark theme and repeat step 1

Expected result

• The checkbox should have a clearly defined and visible outline in both light and dark themes

Actual result

• In light theme, the checkbox from the setting Nightly as the default browser prompt has a barely visible outline. In dark theme, the outline is not visible at all

Regression range

• Potentially regressed by: bug 1968925

Additional notes

• Also reproducing for the checkboxes in the Profile Manager or in Sidebar
• GTK theme: Yaru / Yaru
• See the attached screenshot
• For macOS and Windows, this is tracked in bug 1970096

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1968925, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Kestrel]

Attachment: Page Info controls changed to dark borders

Also see Page Info (Ctrl+I) buttons, checkboxes and radio buttons which now have dark low contrast borders on Ubuntu 25.04 since Bug 1968925.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Yaru-dark checkboxes (from gtk4-demo).

Comment 4

[Emilio Cobos Álvarez [:emilio]]

I'd argue that our rendering matches the native theme better in all these cases. If we want I guess we can use our stand-in colors for yaru and adwaita since those are rather neutral themes..

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1971549 - Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky

Comment 6

[Kestrel]

Attachment: Comparison of checkbox contrast with Yaru-dark theme

The checkbox background is lighter in the gtk4-demo which gives it some contrast and is much easier to see than the ones in Page Info.

Newer GNOME controls in dark mode use lightness for contrast rather than darkness.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f57c5065c19
https://hg.mozilla.org/integration/autoland/rev/581d74688fbb
Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/581d74688fbb

Comment 9

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox Nightly 141.0a1 (2025-06-15) on Ubuntu 22.04. Checkboxes now have a clearly defined and visible outline in both light and dark themes (tested with Yaru and Adwaita OS themes).

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1968925

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for ESR140 when you get a chance.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9494196 [details]
Bug 1971549 - Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: improves checkbox looks on common GTK themes
• User impact if declined:
• Fix Landed on Version: 141
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Color tweaks.

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9494196 [details]
Bug 1971549 - Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky

Approved for 140.2.0esr

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/785f051795db

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/8c3784e3d411

Revert "Bug 1971549 - Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky, for causing linux failures a=backout
https://github.com/mozilla-firefox/firefox/commit/2ce3f80962a5060ad195bbfa7cbfda8ca23cc436

Comment 16

[Dianna Smith [:diannaS]]

Comment on attachment 9494196 [details]
Bug 1971549 - Use stand-in button border colors for yaru / adwaita, or in case we didn't find a suitable one. r=stransky

Backed out of esr140 for causing linux failures
https://treeherder.mozilla.org/logviewer?job_id=521035949&repo=mozilla-esr140

Comment 17

[Emilio Cobos Álvarez [:emilio]]

I think this probably doesn't need uplift, it's a regression from the patch that wasn't uplifted to 140