197086 - XUL / Mozilla Interface (esp. tabs) not repainting properly - Modern Theme

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect, P2)

Description

[WD]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030312

When an area of Mozilla's user interface is invalidated, it doesn't seem to be
repainting properly.

Reproducible: Always

Steps to Reproduce:
1.open some tabs
2.drag a window around over top of the tabs
3.

Actual Results:  
the UI isn't repainting itself properly

Expected Results:  
Repaint properly

Clicking on the tab will have it re-draw itself correctly.

Comment 1

[WD]

Attachment: Screenshot of UI not repainting properly

Comment 2

[Jason Bassford]

I was just about to try to report this (but had no idea how to do so), so am
glad I found it.

Comment 3

[Sébastien Desvignes]

It depends of the theme :
Modern is affected but Classic isn't.

Comment 4

[WD]

*** Bug 197216 has been marked as a duplicate of this bug. ***

Comment 5

[james davis]

Note from my reported dup bug http://bugzilla.mozilla.org/show_bug.cgi?id=197216
that the 1.3 branch doesn't have this issue (with any theme I've tried).
Therefore something changed from the branch since 1.3b left the trunk.
(Thx wd for the dup note.)

Comment 6

[Benjamin Smedberg]

I've seen problems with the borders of tabs not repainting since before 1.2...
it's always been trivial, so I never worried about it. Modern theme/win32.

Testcase for me:
open a browser with tabs
open another window (my xchat window in this case) over the browser
minimize the (xchat) other window

Expected:
no change in the UI

Actual:
the "text" portion of tabs, the URL bar, and the menu bar displays properly. The
borders repaint with background colors/images, but not with border lines.

Comment 7

[R.K.Aa.]

*** Bug 197690 has been marked as a duplicate of this bug. ***

Comment 8

[R.K.Aa.]

This isn't only a Windows problem. I see it on Linux too: tabs sometime have
glitches after a dialog has been open. Button borders in dialog boxes suddenly
crack up slightly.

Comment 9

[Michiel van Leeuwen (email: mvl+moz@)]

Seeing it on linux too. os -> all, component -> GFX

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

Testing by some people in #mozillazine showed that this has been introduced
between 2003031004 and 2003031108.
Looking through the checkins, my guess is the checkin for bug 86249

Comment 11

[Bernd]

Michiel: your guess is right backing out my checkin fixes the border drawing
issue. I believe the patch is correct, but the tab overflow area is wrong.

Comment 12

[Bernd]

Attachment: backout

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I would rather fix the underlying issue than back out correct code. We're still
in alpha.

Comment 14

[Bernd]

Attachment: testcase

Comment 15

[Bernd]

Attachment: patch

I think we should not manipulate the rectangles of composite borders

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 118207 [details] [diff] [review]
patch 

Looks good, but add a comment about why composite borders can't use the trimmed
coordinates.

Comment 17

[Bernd]

fix checked in

Comment 18

[Michael Lefevre]

seems to work ok in 2003032404/win2k.

marking resolved... thanks.