Closed Bug 1971655 Opened 10 months ago Closed 10 months ago

When scrolling, fill new tree-view rows immediately

Categories

(Thunderbird :: Folder and Message Lists, defect)

Thunderbird 135
defect

Tracking

(thunderbird_esr115 wontfix, thunderbird_esr128 affected, thunderbird_esr140+ affected, thunderbird140+ wontfix)

RESOLVED FIXED
141 Branch
Tracking Status
thunderbird_esr115 --- wontfix
thunderbird_esr128 --- affected
thunderbird_esr140 + affected
thunderbird140 + wontfix

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: perf, regression, Whiteboard: [needs performance profile])

Attachments

(1 file)

In bug 1933104 we added a delay (requestAnimationFrame) between tree rows being added to the DOM and those rows being filled. I think this probably makes scrolling look worse because it guarantees there'll be a frame when the rows are empty. As the added frame was only to solve a problem where many row get added to the list in quick succession, I think it's safe to revert to the old behaviour in this specific circumstance (scrolling).

Blocks: 1858030
Target Milestone: --- → 141 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ff98030ceccb
When scrolling, fill new tree-view rows immediately. r=arschmitz

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED

Safe for 140 beta - building on Monday ?

Also affected is esr128, but this hasn't yet gone through beta.

Flags: needinfo?(geoff)
Version: unspecified → Thunderbird 135

Adding here what I wrote in the chat.

I wouldn't recommend taking this to ESR 140.
We want to do some profiling to get the performance delta and learn more about the outcome of the change before considering uplifting.
Scrolling performance is not a reported issue as far as I know so it's safer to let that patch run the train.

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: