1973085 - Newly created folders are not added alphabetically

Status: NEW

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Alessandro Castellani [:aleca]]

After bug 1846550 newly created subfolders are not added alphabetically.

4:06.05 INFO: Last good revision: a315c1a09a8f9d780b3d28621cd68ce1bdd7ee4c
4:06.05 INFO: First bad revision: 61cd87a2f6d0121a6784303b7c6b94e0e11939fc
4:06.05 INFO: Pushlog: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a315c1a09a8f9d780b3d28621cd68ce1bdd7ee4c&tochange=61cd87a2f6d0121a6784303b7c6b94e0e11939fc

Marking this as S2 since the sorting order can be changed, so it's not an inescapable state, just annoying.

Comment 1

[itagagaki]

That is done by a new function folderPane.setSortOrderOnNewFolder(parentFolder, newFolder) added to mail/base/content/about3Pane.js

Comment 2

[Alessandro Castellani [:aleca]]

I can't seem to reproduce this anymore.
My folders order was badly mangled due to bug 1972709, so I had an incorrect initial state.
After resetting the proper order the newly created folders (both IMAP and local) are correctly added alphabetically.

Comment 3

[Toby Pilling [:tobyp]]

Could you please check this functionality works as expected for you and close out if the problem cannot be recreated?

Comment 4

[itagagaki]

I found a code that might be the cause.

https://searchfox.org/comm-central/rev/5bded163fb9a9b9269e8224dcf22b621c611087e/mail/base/content/about3Pane.js#4192-4193

// Skip special folders so new folders don't get created before them.
.filter(folder => folder.flags & Ci.nsMsgFolderFlags.SpecialUse)

Martin, isn't this filter condition the opposite?
This may happen if there is a special folder in sibling folders.