1973777 - Photon Colors theme light sidebar has become dark with low contrast black text

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Kestrel]

Attachment: Sidebar comparison with Photon Colors theme

STR:

1. Install Photon Colors theme (2,342 users).
2. Open the bookmarks sidebar (Ctrl+B).

Expected:
Sidebar is light and/or text has good contrast.

Actual:
Sidebar has dark background with black text and low contrast.

Sidebar header has white text without contrast issue.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a3ce95c88b35238208165e94db12f6b0d970a8cc&tochange=b8fa32e6c490b9b978c64b704fd8ceeb5d1f987d

Regressed by Bug 1968040.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Dupe of bug 1971487, right?

Comment 2

[Kestrel]

No, reproducible on latest Nightly 142.0a1 (2025-06-24).

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I can't repro this... Does this repro on a clean profile for you?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Huh, nvm, I can repro on a clean profile, doesn't repro with sidebar.revamp = true.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1973777 - Stop setting browser color-scheme from contentTheme.js. r=dao,#theme

This was setting the color scheme of the sidebar based off the newtab
colors, so the fact that it worked was total luck.

This was added for bug 1786627 for Firefox View. Instead, make
firefoxview.css and common-shared work with both light and dark modes
via light-dark, and since it wants the same color-scheme as the new tab,
do so.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1973777 - Wallpaper for 140-141: set sidebar background for legacy sidebar on sidebar browser too. r=#theme,#sidebar-reviewers!

This might end up with mismatched colors (dark sidebar header, light
sidebar background), but that's better than the current behavior and
allows you to use the sidebar.

The reason this fixes the issue is that it gets the background-color
from the color-scheme of the #sidebar browser, which is set via style
attribute (see the other patch which removes this behavior).

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9496562 [details]
Bug 1973777 - Wallpaper for 140-141: set sidebar background for legacy sidebar on sidebar browser too. r=#theme,#sidebar-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: prevents unusable sidebar on themes with dark background but light toolbars.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Specific to legacy sidebar and somewhat easy to verify.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Emilio, do you intend to land it on firefox-main before we uplift it the beta and release?

Comment 9

[Emilio Cobos Álvarez [:emilio]]

No, comment 7 is only for beta / release, the right fix is the other patch.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/12aa7c477018
https://hg.mozilla.org/releases/mozilla-beta/rev/c28446b44965

Comment 11

[Timea Zsoldos [:tzsoldos], Desktop QA]

I was able to reproduce the issue on Ubuntu 22 using Firefox build 141.0a1(2025.06.22) and steps from description.
Verified as fixed on Win11/Ubuntu22/Mac 12.6 using Firefox 141.0b2.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6bd70de44b89
https://hg.mozilla.org/releases/mozilla-beta/rev/1de58f537573
Fix ext_themes_sidebar.js

Comment 13

[Emilio Cobos Álvarez [:emilio]]

Still an issue in main.

Comment 14

[Mathew Hodson]

https://phabricator.services.mozilla.com/D254860 was created targeting firefox-autoland so Phabricator didn't close it automatically after the commit was pushed to firefox-beta.

Comment 15

[Kestrel]

Nightly 142.0a1 fix window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e799e1c54cd17da6777b3780f1127350ae9eb113&tochange=f0c5045b9e8ac11e1c0b8927ccbb69430fab1fc8

Likely fixed by Bug 1973817.

Comment 16

[Dão Gottwald [:dao]]

Emilio said his patch may still be worth taking, adding a needinfo as a reminder.

Comment 17

[Donal Meehan [:dmeehan]]

Setting Fx140 to fixed since the regressor was backed out of release
https://bugzilla.mozilla.org/show_bug.cgi?id=1968040#c6

Comment 18

[Donal Meehan [:dmeehan]]

Comment on attachment 9496562 [details]
Bug 1973777 - Wallpaper for 140-141: set sidebar background for legacy sidebar on sidebar browser too. r=#theme,#sidebar-reviewers!

See Comment 17

Comment 19

[Donal Meehan [:dmeehan]]

Setting ESR140 to fixed since the regressor was backed out of ESR140
https://bugzilla.mozilla.org/show_bug.cgi?id=1968040#c8

Comment 20

[Emilio Cobos Álvarez [:emilio]]

Thanks, moved it to bug 1973777.

Comment 21

[Phabricator Automation]

Comment on attachment 9496559 [details]
Bug 1973777 - Stop setting browser color-scheme from contentTheme.js. r=dao,#theme

Revision D254857 was moved to bug 1974573. Setting attachment 9496559 [details] to obsolete.

Comment 22

[Emilio Cobos Álvarez [:emilio]]

bug 1974573 of course :)

Comment 23

[Timea Zsoldos [:tzsoldos], Desktop QA]

Verified as fixed on Windows 11, Ubuntu22 and macOS 10.15 using Firefox 140.0.4, the sidebar is light and/or text has good contrast with Photon Colors theme.

Comment 24

[Timea Zsoldos [:tzsoldos], Desktop QA]

Verified as fixed on Windows 11, Ubuntu22 and macOS 10.15 using Firefox 142.0a1, the sidebar is light and/or text has good contrast with Photon Colors theme.

Comment 25

[Timea Zsoldos [:tzsoldos], Desktop QA]

Verified as fixed on Windows 11, Ubuntu22 and macOS 10.15 using Firefox 140.1.0esr, the sidebar is light and/or text has good contrast with Photon Colors theme.