1974876 - Profile Manager initially appears double width of window on secondary display with primary at 125% fractional scaling

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[masouddehghani]

Attachment: Screenshot_20250630_223532.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:140.0) Gecko/20100101 Firefox/140.0

Steps to reproduce:

Right click on Firefox icon and click on the "Open the Profile Manager" menu.

Actual results:

The window to select the profile has a size problem.

Expected results:

The window should display in a correct size.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Startup and Profile System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Rebecca]

Use moz regression to figure out what regressed this change

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Are you using Wayland fractional scaling by any chance?

Comment 4

[masouddehghani]

Hi,
No, the scaling is set at 100%.

Please see the screenshot here: Screenshot

Thanks

Comment 5

[Emilio Cobos Álvarez [:emilio]]

The built-in screen is at 125% fwiw, might have something to do with it... :)

Could you attach your about:support information to the bug?

Comment 6

[masouddehghani]

Hi,

It's happening on the other screens with 100% scaling but looks fine on the built-in screen.

Please see the requested details: about-support.json

Thanks

Comment 7

[Kestrel]

STR:

1. Set primary display to 125% fractional scaling on Ubuntu 25.04.
2. Set secondary display to 100% scaling.
3. Show Profile Manager on secondary display (firefox -P).

Expected:
Profile Manager content fills window.

Actual:
Profile Manager content is initially too wide for window, double the width. Corrects itself when clicked.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ff5432cc7e7c0d223330a7c8f09a89d797793f83&tochange=9efb94e533503b0cd1309c16d01d488a69941059

Regressed by Bug 581863.

Comment 8

[Kestrel]

The Page Info dialog (Ctrl+I) also flashes too tall briefly on appearance (same regression window).

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1974876 - Don't enforce client-side constraints in RecomputeBounds. r=stransky,thinker

Make sure only that our sizes are sane, which is the point of the check.

Constraints are in device pixels, so when changing scale they may not be
right until layout has updated them.

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1974876 - Minor cleanups to scale change. r=stransky,thinker

This made the logs a bit less confusing to read and should be marginally
faster. No behavior change.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec5fb04ecd55
https://hg.mozilla.org/integration/autoland/rev/9dae8d2dae54
Don't enforce client-side constraints in RecomputeBounds. r=stransky

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9dae8d2dae54

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9501312 [details]
Bug 1974876 - Don't enforce client-side constraints in RecomputeBounds. r=stransky,thinker

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See above
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8fc73c209097
https://hg.mozilla.org/integration/autoland/rev/6b8041925375
Minor cleanups to scale change. r=stransky

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6b8041925375

Comment 17

[Raluca Popovici, Desktop QA]

I was able to reproduce this issue on Ubuntu 22.04 using Fx 141.0b4 with steps from comment 7.
Verified as fixed on Ubuntu 22.04 using Nightly 142.0a1(2025-07-18).

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9501312 [details]
Bug 1974876 - Don't enforce client-side constraints in RecomputeBounds. r=stransky,thinker

Approved for 140.2esr.

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/678a78242158

Comment 20

[Raluca Popovici, Desktop QA]

Fx 140.2.0esr treeherder build from comment 19 is still affected on Ubuntu 24.10. Please see the screenshot(esr).

Comment 21

[Raluca Popovici, Desktop QA]

Attachment: esr.png

Comment 22

[Emilio Cobos Álvarez [:emilio]]

I think you pushed the wrong patch? https://hg.mozilla.org/releases/mozilla-esr140/rev/678a78242158 is the follow-up cleanup (https://hg.mozilla.org/mozilla-central/rev/6b8041925375) not the fix (https://hg.mozilla.org/mozilla-central/rev/9dae8d2dae54)

Comment 23

[Ryan VanderMeulen [:RyanVM]]

Ah, crap. Will fix.

Comment 24

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/9be4894490ef

Comment 25

[Raluca Popovici, Desktop QA]

Verified as fixed in the new 140.2.0esr build as per comment 24 using Ubuntu 24.10.

Comment 26

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c27bc9e43b98
https://hg.mozilla.org/releases/mozilla-release/rev/62e6e1d211a3

Comment 27

[Raluca Popovici, Desktop QA]

Verified as fixed on Ubuntu 24.10 using Fx 141.0.2.