1975391 - Unable to delete selected history entries from sidebar

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Ciprian Georgiu, Desktop QA]

Found in

• Beta 141.0b5

Affected versions

• Firefox 140.0.2
• Beta 141.0b5
• Nightly 142.0a1

Tested platforms

• Affected platforms: Win 11, macOS 15 and Ubuntu 24

Preconditions

• sidebar.revamp = true
• have some history in Firefox

Steps to reproduce

1. Open the History sidebar.
2. Click on a website from the history list, then press Ctrl + A to select all history entries.
3. Press the "Delete" key from the keyboard.

Expected result

• All history entries are deleted.

Actual result

• The history entries cannot be deleted. Nothing happens when pressing the "Delete" key.

Regression range

• Not a regression. It appears that this was not properly implemented in the new sidebar feature.

Additional notes

• This is a follow-up bug for bug 1946971.

Comment 2

[Oluwatobi]

Is this bug open to Outreachy applicants? If so, please assign it to me.

Comment 3

[Oluwatobi]

Attachment: Bug 1975391 - Add logic to allow users to delete sidebar history entries using the keyboard. r=kcochrane,nsharpley

Currently, history entries in the sidebar cannot be deleted with the delete key because the primaryActionHandler event handler, which processes keydown events on the sidebar-tab-row, is not configured to handle delete keyboard events.

This patch updates primaryActionHandler to dispatch a fxview-tab-list-secondary-action event when the delete key is pressed on a sidebar-tab-row. This enables history entry deletion through the delete key, as implemented in sidebar-history.mjs and HistoryController.sys.mjs.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc70739145c6
https://hg.mozilla.org/integration/autoland/rev/58e6ca4c43a3
Add logic to allow users to delete sidebar history entries using the keyboard. r=kcochrane,fxview-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/58e6ca4c43a3