1977270 - Remove API level check for ImeInsetsSynchronizer

Status: RESOLVED WONTFIX

(Firefox for Android :: General, defect, P1)

Description

[Jonathan Almeida [:jonalmeida]]

Similar to bug 1976746, we need to remove the ImeInsetsSynchronizer API level check.

There are also some more unnecessary decor configurations which set in Window.setupPersistentInsets that I will remove here as a follow-up for bug 1976746.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1977270 - Remove API level check for ImeInsetsSynchronizer r=#android-reviewers,aaronmt

This removes more checks for API level for those needed by Reference
Browser. They seem to have zero effect in my local testing across the
affected API versions 30 and 36 for Fenix and Focus, so this ends up
being more dead code and we need to simplify before applying new
configs.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Required by Reference Browser for this patch: https://github.com/mozilla-mobile/reference-browser/pull/3680

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/df2609329deb
https://hg.mozilla.org/integration/autoland/rev/2c08c7bef48e
Remove API level check for ImeInsetsSynchronizer r=android-reviewers,nalexander

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/2c08c7bef48e

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Attachment: Revert "Bug 1977270 - Remove API level check for ImeInsetsSynchronizer r=#android-reviewers"

This reverts commit df2609329debb47e398a22fa26bdbd41f5eda796.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: RBPaddingBug.mp4

Because of this patch removing the Android 13 guard I'm seeing in Reference Browser the same bug we avoided in Fenix a while ago (Fenix recording here)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/272defa6cd1d
https://hg.mozilla.org/integration/autoland/rev/c955ec98b47f
Revert "Bug 1977270 - Remove API level check for ImeInsetsSynchronizer r=android-reviewers,jonalmeida"

Comment 8

[Goloman Adrian[:agoloman]]

Backout merged into central.

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Various layout issues with extra padding applied when browsing. See bug 1987065 and bug 1979064.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check the scenarios from bug 1987065 and bug 1979064.
• Risk associated with taking this patch: low
• Explanation of risk level: Small change - just an if check to avoid the using buggy functionality on Android 13 and below.
• String changes made/needed: --
• Is Android affected?: yes

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Attachment: Revert "Bug 1977270 - Remove API level check for ImeInsetsSynchronizer r=#android-reviewers"

This reverts commit df2609329debb47e398a22fa26bdbd41f5eda796.
Needed to fix bug 1979064.

Original Revision: https://phabricator.services.mozilla.com/D265589

Comment 11

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Various layout issues with extra padding applied when browsing. See bug 1987065 and bug 1979064.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Check the scenarios from bug 1987065 and bug 1979064.
• Risk associated with taking this patch: low
• Explanation of risk level: Small change - just an if check to avoid the using buggy functionality on Android 13 and below.
• String changes made/needed: --
• Is Android affected?: yes

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Revert "Bug 1977270 - Remove API level check for ImeInsetsSynchronizer r=#android-reviewers"

This reverts commit df2609329debb47e398a22fa26bdbd41f5eda796.
Needed to fix bug 1979064.

Original Revision: https://phabricator.services.mozilla.com/D265589

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/073709f7dba6
https://hg.mozilla.org/releases/mozilla-release/rev/83f3be290bef

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/17be5d971b6a
https://hg.mozilla.org/releases/mozilla-beta/rev/7681f35edf97

Comment 15

[Mira Lobontiu (Android QA)]

I'll remove the qe-verify+ label, considering this comment on Bug 1979064, and this comment on Bug 1987065.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

This original bug filed here isn't fixed. It was reverted from all branches.

Comment 17

[Petru-Mugurel Lingurar [:petru]]

@Jonathan Should these be closed as wontfix?

Comment 18

[Jonathan Almeida [:jonalmeida]]

Sure, we can always reopen after bug 1990003.