1977955 - Account Hub Email: Allow users to cancel loading animation

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Vineet Deo]

• Currently the spinning overlay in account hub for email takes over the screen and isn’t cancel-able, leading to issues when there is an error in the middle of loading
• This task is for bringing forward the cancel button in the footer on top of the overlay so the user can cancel whichever abortable task is running.

Comment 1

[Martin Giger [:freaktechnik]]

Do you want a separate bug to also handle Escape properly, since currently it just closes the account hub and leaves it in the same state?

Comment 2

[Vineet Deo]

(In reply to Martin Giger [:freaktechnik] from comment #1)

Do you want a separate bug to also handle Escape properly, since currently it just closes the account hub and leaves it in the same state?

Yes I think a separate bug would be good for that.

Comment 3

[Vineet Deo]

Attachment: Bug 1977955 - Account Hub Email: Allow users to cancel loading animation. r=#thunderbird-reviewers

How to Test

• When some sort of network request happens, the user should be able to hit cancel, withholding account creation and waiting for OAuth
• The cancel button should be above the loading overlay
• The following places is where you can cancel the request:
• First step when trying to find a config
• Autodiscover Password step when trying to find a config
• When Address Books and Calendars are being fetched
• When a manual configuration is being tested
• When an exchange add-on is being installed in the config found page

Comment 5

[Vineet Deo]

Attachment: Bug 1977955 - Add tests for cancelling loading operations in account hub for email. r=#thunderbird-reviewers

Depends on D261471

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4fab7ff15ec0
Account Hub Email: Allow users to cancel loading animation. r=arschmitz
https://hg.mozilla.org/comm-central/rev/4fe203d97b16
Add tests for cancelling loading operations in account hub for email. r=arschmitz