1979014 - Make a few XUL attributes simpler.

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1979014 - Make some XUL attributes (hidden/collapsed/autofocus) regular bool attributes. r=dao

I audited a bit and non-test things use the script setter, which already
removed the attribute, so should be fine / no behavior change in that
regard.

This came up while reviewing some code for the native menubar code on
Linux, which uses SetBoolAttr() and doesn't hide the menubar now:

https://searchfox.org/mozilla-central/rev/86878e73a24fe32ea09dbae5b55362efaf7485c8/widget/gtk/NativeMenuGtk.cpp#770,785,790

That is disabled by default tho.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1979014 - Remove broken browser_private_browsing_simplified_ui.js. r=dwalker,cmkm

This test starts failing with the other patch in this bug, but that's
because the feature it's testing was removed (bug 1883140), and the test
is just broken: It expected the collapsed attribute to be missing, but
before my patch you get collapsed="false", which is still truthy from
getAttribute().

Comment 3

[Emilio Cobos Álvarez [:emilio]]

FYI, this will probably impact at least TB tests.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

(ah Markus is out)

Comment 5

[Richard Marti (:Paenglab)]

Thanks for the heads up.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1979014 - Fix XULStore.persist() for missing attributes. r=dao,mossop

This matches the changes from bug 15232, and is needed for the other
patch in this bug, as otherwise we won't persist the removed autohide
attribute of the menubar properly (for example).

Would be good to more directly use XULPersist.cpp, perhaps...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1b2b36644315
https://hg.mozilla.org/integration/autoland/rev/4adc15391f08
Fix XULStore.persist() for missing attributes. r=mossop

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/03d7219a91e8
https://hg.mozilla.org/integration/autoland/rev/0bf082017f90
Remove broken browser_private_browsing_simplified_ui.js. r=dwalker

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4adc15391f08

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bf082017f90

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0aa2101448ac
https://hg.mozilla.org/integration/autoland/rev/98bcb3a4ff0a
Make some XUL attributes (hidden/collapsed/autofocus) regular bool attributes. r=dao,desktop-theme-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,nchevobbe,search-reviewers,daleharvey,dimi

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36639999b398
https://hg.mozilla.org/integration/autoland/rev/3c5221a65ee8
Fix some tests.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d042178d924
https://hg.mozilla.org/integration/autoland/rev/70eab402cc8d
Prevent window controls from being incorrectly hidden on macOS.

Comment 14

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1979014 - Fix cocoa native menu handling after the previous patches. r=#mac-reviewers!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dbbf2d7eec62
https://hg.mozilla.org/integration/autoland/rev/3bdbf0109f6b
Fix cocoa native menu handling after the previous patches. r=mac-reviewers,mstange

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/68683a5d7511
https://hg.mozilla.org/integration/autoland/rev/ee19b9c08506
Fix test_standalone_native_menu.xhtml

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/98bcb3a4ff0a
https://hg.mozilla.org/mozilla-central/rev/3c5221a65ee8
https://hg.mozilla.org/mozilla-central/rev/70eab402cc8d
https://hg.mozilla.org/mozilla-central/rev/3bdbf0109f6b
https://hg.mozilla.org/mozilla-central/rev/ee19b9c08506

Comment 18

[Cosmin Sabou [:CosminS]]

Emilio, could the changes here be the root cause for Bug 1980037, Bug 1979993, Bug 1979994, Bug 1980028, Bug 1980040, Bug 1980042, Bug 1980044.
They all started with this merge: https://hg-edge.mozilla.org/mozilla-central/pushloghtml?changeset=d7eb324b222d504f43ff0edbc431daac6df35581

Comment 19

[Emilio Cobos Álvarez [:emilio]]

No. Those are most likely from https://hg-edge.mozilla.org/mozilla-central/rev/90723b8a3963034dad826e37278a3cb2492b4e33 which touched a file that all those reference. I think Benjamin is familiar with FedCM and could evaluate if they are legit bugs or something else.

Comment 20

[Benjamin VanderSloot [:bvandersloot]]

Any FedCM WPT failures should probably be ignored until implement the WebDriver support for FedCM extensions in Bug 1945580.

Comment 21

[Magnus Melin [:mkmelin]]

Sure would be nice if this worked for disabled as well. ;-)