Closed Bug 1989214 Opened 1 year ago Closed 1 month ago

Upgrade to v143 (and 153) turned off composition toolbar, so Send button missing. Resolved by Troubleshoot Mode, or cycling the settings.

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 143
Desktop
All
defect

Tracking

(thunderbird_esr140 unaffected, thunderbird_esr153 fixed, thunderbird155 fixed)

RESOLVED FIXED
156 Branch
Tracking Status
thunderbird_esr140 --- unaffected
thunderbird_esr153 --- fixed
thunderbird155 --- fixed

People

(Reporter: m.marchi, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression)

Attachments

(5 files, 1 obsolete file)

Attached image bug_tb_send.jpg —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36

Steps to reproduce:

After installing I runa the application. When I try to write a news or I try to answer to an incoming message the button "Send" is not visibile (incredible ...).

Actual results:

I cannot use mail client.

Summary: I just updated Thunderbird to release , under Windows 11 PRO,H2, build 26100.6584. When i click on new message or I want to answer to a received message the button "send" is not visibile, so I cannot use mail client. → I just updated Thunderbird to release 143, under Windows 11 PRO,H2, build 26100.6584. When i click on new message or I want to answer to a received message the button "send" is not visibile, so I cannot use mail client.
Summary: I just updated Thunderbird to release 143, under Windows 11 PRO,H2, build 26100.6584. When i click on new message or I want to answer to a received message the button "send" is not visibile, so I cannot use mail client. → I just updated Thunderbird to release 143, under Windows 11 PRO, 24H2, build 26100.6584. When i click on new message or I want to answer to a received message the button "send" is not visibile, so I cannot use mail client.
OS: Unspecified → Windows 11
Hardware: Unspecified → Other

I understood (and solved) the problem: in the writing/responding window, in the tools bar, the composition tools menù was disabled by default (no comment ...).
Now the issue has been solved, send button appears either in the new message window or in the responding window.

I wasn't able to recreate this. I just upgraded from 142->143 (Linux) and the composition toolbar was enabled by default, send buttons appeared by default.

Which version did you upgrade from?

Component: Untriaged → Message Compose Window
See Also: → 1989026
Summary: I just updated Thunderbird to release 143, under Windows 11 PRO, 24H2, build 26100.6584. When i click on new message or I want to answer to a received message the button "send" is not visibile, so I cannot use mail client. → Upgrade to v143 turned off composition toolbar
Duplicate of this bug: 1989521
See Also: → 1989658

I ran into the same problem - no composition toolbar in a Write window - after updating from TB 142.0 to 143.0 on Linux.

Status: UNCONFIRMED → NEW
Ever confirmed: true

FWIW I'm not seeing this with 144.0b1 on mac

OS: Windows 11 → All
Hardware: Other → All
Summary: Upgrade to v143 turned off composition toolbar → Upgrade to v143 turned off composition toolbar, so Send button missing
Duplicate of this bug: 1990065
Duplicate of this bug: 1991042

I installed Thunderbird 142.0 and allowed it to auto-update to 143.0, but I could not reproduce the reported issue.
To test the above, I used a new profile with only a POP account.

In addition, even though the Formatting toolbar was enabled, it was hidden.
Clicking to disable it did the trick to make it available (w/o actually disabling it). Subsequent Enable/Disable behave correctly

Hello,

I solved the problem by enabling "troubleshoot mode" in the "help" tab.
Restart and check "reset toolbars and control bars" then click "make changes and restart".

All is ok now !

Duplicate of this bug: 2014662
Severity: -- → S4
Summary: Upgrade to v143 turned off composition toolbar, so Send button missing → Upgrade to v143 turned off composition toolbar, so Send button missing. Resolved by Troubleshoot Mode, or cycling the settings.

Several reports of this in August, and found others from March, and last fall.

Summary: Upgrade to v143 turned off composition toolbar, so Send button missing. Resolved by Troubleshoot Mode, or cycling the settings. → Upgrade to v143 (and 153) turned off composition toolbar, so Send button missing. Resolved by Troubleshoot Mode, or cycling the settings.
Duplicate of this bug: 2059704
Duplicate of this bug: 2061265

Hi all,

in very old profiles xulstore.json the following could be effectively contained:

"composeToolbar2":{"collapsed":"false"}

Before bug 1979014 this meant visible while afterwards the mere presence of the collapsed attribute now means invisible.

This value was produced by unmodified Thunderbird between 9 and 60: https://searchfox.org/comm-esr60/source/mail/base/content/mailCore.js#331-334

No idea whether it is still worth it to ship a fix/workaround or not.

Cheers

Max

Regressed by: 1979014
Hardware: All → Desktop
Duplicate of this bug: 2062736

It would seem that the migration via Bug 1989026 fixed in v145 - Upgrading from 142.x to 143 will hide the Menu bar - is not sufficient for this bug.

Do we need a variation of that migration for compose toolbar, or others?

Flags: needinfo?(mkmelin+mozilla)

(In reply to Wayne Mery (:wsmwk) from comment #20)

It would seem that the migration via Bug 1989026 fixed in v145 - Upgrading from 142.x to 143 will hide the Menu bar - is not sufficient for this bug.

Do we need a variation of that migration for compose toolbar, or others?

composeToolbar2, compose-toolbar-menubar2 (only ever written on Windows) and mail-bar3 are the only ones left in this class.

This could be an easy fix, but we should not forget to bump up UI_VERSION.

However, considering the amount of time that has passed I am wondering whether this late fix is the right choice vs providing guidance on how to reset.

What do y'all think?

Release channel users (mostly?) no longer matter. It's esr users who have not yet updated to 153 that are potentially affected, and esr is the bulk of our users. And importantly, a secondary thought is enterprise users on esr (and possibly non-esr) who don't use our update services so they can ship on their own schedule.

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mkmelin+mozilla)
Target Milestone: --- → 156 Branch

For QA:
1: install an old Thunderbird (v9-60), e.g. Thunderbird45.
2: in the compose window toggle View | Composition Toolbar (this is the toolbar with Send button) and close the window
3: reopen the compose window and re-enable the composition toolbar
4: upgrade to Daily (from later today, 2026-11-18 or later). Check that the compose window still has the Composition Toolbar showing

That's the most important case. You can also check variations where hidden compose toolbar also persists as it were... but frankly it's not a valid use case and we would be better not having that possibility.

Flags: needinfo?(vlucaci)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/45770ba467c6
Migrate old persisted collapse value to boolean attribute. r=tobyp,maxe

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

Hello!
I have tested this on Win 11.
I downloaded TB 78(20200713151512) configured an IMAP account using a gmail provider.
Compose a new message and toggle with the Composition Toolbar and closed the window.
Opened the window again and re-enabled the Composition Toolbar.
Updated to TB 156.0a1(20260818104649) the Composition Toolbar was present after the upgrade.
Restarted TB, when TB opened again the Composition Toolbar was present.

Notes:
I have tried even older builds TB 45.2.0, TB 45.8.0 TB 52.0, TB 60.0 but I wasn’t lot able to configure an account.

I also tried the enable/disable Composition Toolbar multiple times before upgrading to latest daily, and everything worked as expected.
I also tried restarting TB multiple times before upgrading to latest daily and everything worked as expected as expected.

Flags: needinfo?(vlucaci)

Pushed by brendan@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/722a20e15399
follow-up, fix mail/test/marionette/test_collapsed_toolbar_migration.py. r=tobyp

Probably border-line sev 2 / sev 3. There's a work-around, but this appears to affect a large number of installations.

Severity: S4 → S2

Magnus, I'm going to mark this for uplift to beta and esr153. Can you let me know there's any reason not to?

Comment on attachment 9627330 [details]
Bug 1989214 - Migrate old persisted collapse value to boolean attribute. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta
Approved for esr153

Attachment #9627330 - Flags: approval-comm-esr153+
Attachment #9627330 - Flags: approval-comm-beta+

(In reply to Corey Bryant from comment #31)

Magnus, I'm going to mark this for uplift to beta and esr153. Can you let me know there's any reason not to?

I agree that an uplift is warranted here and see no reason against it.

I think this will need a separate patch for the UI version, since I think that's changed since 153 and the patch here.

Edit: yeah bug 2044250 is marked for 154 and set the previous UI version.

Do the migration for users who already didn't upgrade.

I added https://phabricator.services.mozilla.com/D321174 for v153. This will handle users who didn't upgrade yet.

Comment on attachment 9630492 [details]
Bug 1989214 - [comm153esr] Migrate old persisted collapse value to boolean attribute. r=tobyp,maxe

[Triage Comment]
Approved for esr153

Attachment #9630492 - Flags: approval-comm-esr153+
Attachment #9627330 - Flags: approval-comm-esr153+ → approval-comm-esr153-

Comment on attachment 9630812 [details]
Bug 1989214 - [comm153esr] Migrate old persisted collapse value to boolean attribute. r=tobyp,maxe

[Triage Comment]
Approved for esr153

Attachment #9630812 - Flags: approval-comm-esr153+

Comment on attachment 9630492 [details]
Bug 1989214 - [comm153esr] Migrate old persisted collapse value to boolean attribute. r=tobyp,maxe

[Triage Comment]
Test failures

Attachment #9630492 - Flags: approval-comm-esr153+ → approval-comm-esr153-

Due to https://hg.mozilla.org/releases/comm-esr153/rev/f4afd6a893d7 the 61 migrations need to happen for 62 too, when that time comes.

Attachment #9630492 - Attachment is obsolete: true

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/05db7aa6cc98
Do v61 migrations for v62 too, as esr153 did its own v61. r=tobyp

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: