1979434 - Pressing the [ENTER] key does not search the bookmark Sidebar/Library again with the same search term.

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Open Bookmarks Sidebar Ctrl+B or Library Ctrl+O
2. Type search term (e.g., f) in Search field and hit [ENTER]
3. Right-click on a search result
4. Choose Show in folder
5. Click on the Search field to focus
6. Hit [ENTER]

Actual results:
Nothing happens

Expected results:
Search with the term.
OR
Clear search term at step 4 like previous version.

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=48d34ac93eaf2fbe0e36bc934af2bb1a85f508e6&tochange=263bab4209ad7a516863be36705adb00b967f85c

Good build: the search term is cleared at step4
Bad build: the search term is not cleared at step4, and this bug appears.

This is not a pure regression, but it causes obvious UX issues.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1967209, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1979434 - MozInputSearch.clear() should also clear the inner input value. r=#recomp-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d12c6a61ecc5
https://hg.mozilla.org/integration/autoland/rev/c077d01c98f2
MozInputSearch.clear() should also clear the inner input value. r=reusable-components-reviewers,akulyk

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c077d01c98f2

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9503246 [details]
Bug 1979434 - MozInputSearch.clear() should also clear the inner input value. r=#recomp-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Trivial regression fix
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix is a one liner.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9503246 [details]
Bug 1979434 - MozInputSearch.clear() should also clear the inner input value. r=#recomp-reviewers

Approved for 142.0b8

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9c018927a518
https://hg.mozilla.org/releases/mozilla-beta/rev/e8eb49702b6c

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 22 Dec-9 Jan, please ni? :mboldan]]

Reproduced the issue with Firefox 143.0a1 (2025-07-25) on Windows 10x64 by following the steps from comment 0.
The issue is verified fixed with 143.0a1 (2025-08-07) and 142.0b8 on Windows 10x64, macOS 12 and Ubuntu 24 for the Sidebar part. After using the Show in folder option, the search input is cleared.
However, I can still reproduce the issue inside the Library after following the steps from comment 0. I have filed a follow-up for this (bug 1981925)