1967209 - Bookmarks sidebar textbox lacks padding compared to history

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Kestrel]

Attachment: Bookmarks sidebar search textbox comparison (latest on right)

STR:

1. Open the bookmarks sidebar (Ctrl+B) on Ubuntu 25.04.
2. Compare with the history sidebar (Ctrl+H).

Expected:
Bookmarks search textbox is padded like rest of interface.

Actual:
Search textbox is oddly compact.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f781ab633afe8b664eed540a45ea6a1398a72849&tochange=34410bd3a248cada7fd1ee864df825728e700321

Regressed by Bug 1963446.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1963446, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

The padding is specified here, the "issue" is that now we honor it (we used to get the padding from the GTK theme).

We could bump it I guess. Tim has been looking at this component recently... Any strong opinion either way?

Comment 3

[Tim Giles [:tgiles] | OOO Dec 19 - Jan 6]

No strong opinion here. I'm in the mindset that the search-textbox is a legacy component, so if we need to fix up padding or other minor items, then I don't see an issue there. In the future ™ we would switch <search-textbox> to the new <moz-input-search>, but that's not a priority right now.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1963446

Comment 5

[Greg Stoll :gstoll]

Hi Emilio - do you think we can get a fix for this and uplift to 140? Thanks!

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1967209 - Use <moz-input-search> in history/bookmarks sidebars. r=#places-reviewers,tgiles

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1967209 - Use <moz-input-search> in legacy synced tabs sidebar. r=#sidebar-reviewers,tgiles

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/772f2b73a00c
https://hg.mozilla.org/integration/autoland/rev/1af8fa5e85e1
Use <moz-input-search> in history/bookmarks sidebars. r=places-reviewers,desktop-theme-reviewers,hjones,reusable-components-reviewers,Standard8
https://github.com/mozilla-firefox/firefox/commit/9b3a92a6e2ea
https://hg.mozilla.org/integration/autoland/rev/263bab4209ad
Use <moz-input-search> in legacy synced tabs sidebar. r=sidebar-reviewers,desktop-theme-reviewers,sclements,hjones

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1af8fa5e85e1
https://hg.mozilla.org/mozilla-central/rev/263bab4209ad

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox140 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Emilio Cobos Álvarez [:emilio]]

I think this is probably WONTFIX for 140, or we'd need to also uplift bug 1055085 and other improvements too.