1981524 - Enable notifications for new EWS messages

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

As part of phase three operations, add the ability for users to see notifications when new email messages arrive.

Geoff mentioned...

there's no notifications about the BiffState folder property changing, that'll probably be why

Comment 1

[Takanori MATSUURA]

Since bug 1981208 blocks bug 1847846, there is no need to set both in "Blocks."

Comment 2

[Brendan Abolivier [:babolivier]]

(In reply to Takanori MATSUURA from comment #1)

Since bug 1981208 blocks bug 1847846, there is no need to set both in "Blocks."

There is, because bug 1847846 allows us to get a better grasp on the outstanding Exchange work needed as a whole (more easily than with the full dependency graph), whereas bug 1981208 gives us a filtered-down version of the current phase (and also mostly exists to help with integration into external tools).

Comment 3

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

I'm working on expanding one of the notifications tests to handle new messages arriving in EWS. If you are fixing this bug and want to compare behaviour with IMAP, run the test, it logs all of the folder property changes that happen.

Basically, if BiffState changes to 0, or NewMailReceived changes to anything (this isn't a real property, but it's the "change" we're listening for), the notification code does its thing. This is poorly documented and untested, so I'm still having to work out the true intent of some things. E.g. I don't think there are supposed to be notifications if it's the user that checked for mail (server.performingBiff == false), only if an automatic change happened (server.performingBiff == true). But the current behaviour isn't at all consistent with that theory.

At this point in time I've modified the test to check that what I think is supposed to happen, happens. Obviously it's not all passing.

Comment 4

[Geoff Lankow (:darktrojan) [OOO, back 7 Apr]]

I've marked the test for landing. If you're working on this please remove enable the two skipped sections that test EWS.

Comment 5

[Eleanor Dicharry]

Attachment: Bug 1981524 - Enable notifications for new EWS messages. r=#thunderbird-back-end-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/89ea160cd46a
Enable notifications for new EWS messages. r=mkmelin