1981535 - Enable search for EWS messages

Status: RESOLVED WORKSFORME

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

As part of phase three operations, add the ability for users to search for email messages within an EWS account.

Comment 1

[Takanori MATSUURA]

Since bug 1981208 blocks bug 1847846, there is no need to set both in "Blocks."

Comment 2

[Brendan Abolivier [:babolivier]]

(In reply to Takanori MATSUURA from comment #1)

Since bug 1981208 blocks bug 1847846, there is no need to set both in "Blocks."

There is, because bug 1847846 allows us to get a better grasp on the outstanding Exchange work needed as a whole (more easily than with the full dependency graph), whereas bug 1981208 gives us a filtered-down version of the current phase (and also mostly exists to help with integration into external tools).

Comment 3

[Toby Pilling [:tobyp]]

We also have automation between Bugzilla and Notion which uses a mapping of milestone to meta bug which is the case in this instance. Thanks for the intention though!

Comment 4

[Toby Pilling [:tobyp]]

Magnus,
Would you be able to investigate to better understand what currently works in terms of search within an EWS account - and what would be required to have it work reliably?

Comment 5

[Magnus Melin [:mkmelin]]

For Gloda, trying to test - after moving a message to another folder I get

TypeError: can't access property "spec", aRequest.URI is undefined 2 MimeMessage.sys.mjs:136:64
    onDataAvailable resource:///modules/gloda/MimeMessage.sys.mjs:136

While there's a bug in the actual throwing there (should null-check URI), we shouldn't be getting there anyway. See the explanation
https://searchfox.org/comm-central/rev/854912897c5895bb97282a523d649e2cf8c139f0/mailnews/db/gloda/modules/MimeMessage.sys.mjs#134
That is, seems there's some bug in the streaming for EWS.

Assuming this happens all the time, I assume Gloda won't work at all for ews until that bug is fixed.
For context, Gloda keeps track on when a folder gets new messages and tries to index them when that happens.

Comment 6

[Magnus Melin [:mkmelin]]

With that patched (https://phabricator.services.mozilla.com/D263367), I get
`JavaScript error: resource:///modules/gloda/MimeMessage.sys.mjs, line 138: Error: The stream converter should have grabbed the data for x-moz-ews://[e-mail]/Left/1?convert=true´

Comment 7

[Magnus Melin [:mkmelin]]

Same for the o365 test account.
Error: The stream converter should have grabbed the data for x-moz-ews://[e-mail]/Inbox/2?convert=true 2 MimeMessage.sys.mjs:138:11
The error gets triggered also e.g. by tagging a message

That account does get some messages indexed, so it's not all broken. There may be some connection to whether that message is already fully downloaded (or recently viewed?), as some messages turn up after a while after I view them and search again.

Comment 8

[Toby Pilling [:tobyp]]

Perhaps this overlaps with some of Ben's work in bug 1986399. Let's help him move it forwards and retest this on top of his work?

Comment 9

[Magnus Melin [:mkmelin]]

After I apply the stack from bug 1986399 and re-test, search seems to work, at least to a good degree.
The error from above still happens though, so it seems likely that everything isn't indexed quite ok (but I don't know what isn't).

Comment 10

[Brendan Abolivier [:babolivier]]

The "Search Messages" dialog now works with EWS (bug 1986621). Other methods of search (gloda and quick search) have been working for a while too, so this bug can be closed. The only caveat is that searching through message bodies can feel inconsistent because of our message download policy, but that's being fixed in bug 1986399.