Open Bug 1981871 Opened 9 months ago Updated 6 months ago

Make `rusttests` support running tests with `cargo` directly

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

ASSIGNED

People

(Reporter: bdk, Assigned: bdk)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsync-])

Attachments

(1 file)

./mach rusttests currently hooks directly into the build process, running tests using the same Makefile that we build libxul with. We should extend this command to also support tests being run via cargo test -p [crate-name]. This will work better with a lot of app-services crates, for example once https://bugzilla.mozilla.org/show_bug.cgi?id=1981745 is implemented then the tests can link to libsqlite for free. With the makefile-based approach this becomes more complicated (https://phabricator.services.mozilla.com/D257895 implements it, but it's not so simple).

Eventually, we might want to move all tests to using cargo but for the initial implementation I think we should support a hybrid approach.

This is a WIP until the app-services monorepo project is more finalized
and we can rebase this on top of a commit that vendors in all the
app-services crates.

My main question is if this seems good as a general approach.

Priority: -- → P3
Assignee: nobody → bdeankawamura
Status: NEW → ASSIGNED
Attachment #9506043 - Attachment description: WIP: Bug 1981871 - Make `./mach rusttests` run some tests via cargo directly, r=glandium,markh → Bug 1981871 - Make `./mach rusttests` run some tests via cargo directly, r=glandium,markh
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: