Closed Bug 1982060 Opened 11 months ago Closed 9 months ago

Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut

Categories

(Firefox :: Installer, defect, P2)

Product:
Firefox
Component:
Installer
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
145 Branch
Tracking Flags:
Tracking Status
firefox145 --- fixed

People

(Reporter: cdupuis, Assigned: cdupuis)

References

Details

(Whiteboard: [fidedi])

Attachments

(2 files, 2 obsolete files)

Bug 1982060 - Part 1: Create util for handling shell var context
48 bytes, text/x-phabricator-request
Details | Review
Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut
48 bytes, text/x-phabricator-request
Details | Review

The Desktop Launcher app already respects the choice of users who have removed the app, by not reinstalling on update.

However, users who have removed the desktop icon are unlikely to appreciate having a new icon appear on their desktop, even if it has additional functionality.

This means that, on update, we should only install the desktop launcher if:

  • The desktop launcher is already installed (this is how the launcher is updated)
    OR
  • There is currently a shortcut icon on the user's Desktop

This is a little complicated, because the actual installed location of the shortcut icon is in the C:\Users\Public folder. Need to see what controls making items in this folder not be displayed when a user deletes them from their own desktop.

:cdupuis Given this is P2 are you taking it on/assigning it?

Flags: needinfo?(cdupuis)
Duplicate of this bug: 1984555
Blocks: 1985118
Flags: needinfo?(cdupuis)
Blocks: 1985160
Assignee: nobody → cdupuis
Whiteboard: [fidedi]

If there is no Firefox shortcut on the desktop, one should not appear on update.

Duplicate of this bug: 1981911
Attachment #9510223 - Attachment description: Bug 1982060 - Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut r=hsohaney,mpohle,nrishel → WIP: Bug 1982060 - Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut r=hsohaney,mpohle,nrishel
Attachment #9510223 - Attachment description: WIP: Bug 1982060 - Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut r=hsohaney,mpohle,nrishel → WIP: Bug 1982060 - Part 1: Create stack-based shell var context handler
Attachment #9511766 - Attachment description: WIP: Bug 1982060 - Placeholder commit → WIP: Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut
Attachment #9511731 - Attachment description: WIP: Bug 1982060 - Part 1: Create stack-based shell var context handler → Bug 1982060 - Part 1: Create stack-based shell var context handler
Attachment #9511732 - Attachment description: WIP: Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut → Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut
Attachment #9511731 - Attachment is obsolete: true
Attachment #9511766 - Attachment description: WIP: Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut → Bug 1982060 - Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut
Attachment #9510223 - Attachment description: WIP: Bug 1982060 - Part 1: Create stack-based shell var context handler → Bug 1982060 - Part 1: Create stack-based shell var context handler
Attachment #9511732 - Attachment is obsolete: true
Attachment #9510223 - Attachment description: Bug 1982060 - Part 1: Create stack-based shell var context handler → Bug 1982060 - Part 1: Create utils for handling stack var context
Attachment #9510223 - Attachment description: Bug 1982060 - Part 1: Create utils for handling stack var context → Bug 1982060 - Part 1: Create util for handling shell var context
Pushed by cdupuis@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7c3b9f432612 https://hg.mozilla.org/integration/autoland/rev/45449aa7c00d Part 1: Create util for handling shell var context r=browser-installer-reviewers,bytesized,dmcintosh https://github.com/mozilla-firefox/firefox/commit/fbe1964ca89f https://hg.mozilla.org/integration/autoland/rev/0484c5faf072 Part 2: Make Desktop Launcher respect choice of users who have already removed the Firefox desktop shortcut r=bytesized,dmcintosh,browser-installer-reviewers

https://hg.mozilla.org/mozilla-central/rev/45449aa7c00d
https://hg.mozilla.org/mozilla-central/rev/0484c5faf072

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox145: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Depends on: 1991903
No longer depends on: 1991903
QA Whiteboard: [qa-triage-done-c146/b145] [qa-ver-needed-c146/b145]
Flags: qe-verify+
No longer blocks: 1985160
Duplicate of this bug: 1986562
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: