1982429 - use SpecialPowers.pushPrefEnv instead of Services.prefs for some mochitests

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Per bug 1977567 comment 6:
"In general, in browser tests and mochitests you should use SpecialPowers.pushPrefEnv instead of using Services.prefs API, because the test-only SpecialPowers.pushPrefEnv API automatically cleans up preferences at the end of the test, even if you forget (or intentionally omit) the countering SpecialPowers.popPrefEnv call"

Comment 1

[Toby Pilling [:tobyp]]

Attachment: Bug 1982429 - Use SpecialPowers.pushPrefEnv in mochitests. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c841d450ab2
Use SpecialPowers.pushPrefEnv in mochitests. r=arschmitz

Comment 3

[Magnus Melin [:mkmelin]]

It seems there's a whole lot more of these left: https://searchfox.org/comm-central/search?q=Services.prefs.set&path=browser_&case=false&regexp=false - both mail and calendar

Comment 4

[Toby Pilling [:tobyp]]

wow, ok thanks

Comment 5

[Toby Pilling [:tobyp]]

Attachment: Bug 1982429 - Use SpecialPowers.pushPrefEnv in calendar browser tests. r=#thunderbird-reviewers

Comment 6

[Toby Pilling [:tobyp]]

Sorry, this is going to span target milestones but is only test changes. Hope that's ok

Comment 7

[Toby Pilling [:tobyp]]

No it's not. Making another bug

Comment 8

[Phabricator Automation]

Comment on attachment 9631162 [details]
Bug 1982429 - Use SpecialPowers.pushPrefEnv in calendar browser tests. r=#thunderbird-reviewers

Revision D321569 was moved to bug 2066871. Setting attachment 9631162 [details] to obsolete.