2066871 - use SpecialPowers.pushPrefEnv instead of Services.prefs for remaining mochitests

Status: ASSIGNED

(Thunderbird :: General, defect)

Description

[Toby Pilling [:tobyp]]

Per bug 1977567 comment 6:
"In general, in browser tests and mochitests you should use SpecialPowers.pushPrefEnv instead of using Services.prefs API, because the test-only SpecialPowers.pushPrefEnv API automatically cleans up preferences at the end of the test, even if you forget (or intentionally omit) the countering SpecialPowers.popPrefEnv call"

Comment 1

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in calendar browser tests. r=#thunderbird-reviewers

Comment 2

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in mail base browser tests. r=#thunderbird-reviewers

Comment 3

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in additional mail base browser tests. r=#thunderbird-reviewers

Comment 4

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in preferences and address book browser tests. r=#thunderbird-reviewers

Comment 5

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in mail component browser tests. r=#thunderbird-reviewers

Comment 6

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in WebExtension compose and message-list browser tests. r=#thunderbird-reviewers

Comment 7

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in account and attachment browser tests. r=#thunderbird-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11bf9f2f231b
Use SpecialPowers.pushPrefEnv in calendar browser tests. r=aleca

Comment 9

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in composition browser tests. r=#thunderbird-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/92d8cd2b3e16
Use SpecialPowers.pushPrefEnv in mail base browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/9aa35bf602b7
Use SpecialPowers.pushPrefEnv in additional mail base browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/48b0c2ee729a
Use SpecialPowers.pushPrefEnv in preferences and address book browser tests. r=aleca

Comment 11

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in folder display browser tests. r=#thunderbird-reviewers

Comment 12

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in misc mail browser tests. r=#thunderbird-reviewers

Comment 13

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in remaining WebExtension browser tests. r=#thunderbird-reviewers

Comment 14

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in CloudFile, message reader, and notification browser tests. r=#thunderbird-reviewers

Comment 15

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in OpenPGP and S/MIME browser tests. r=#thunderbird-reviewers

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f6518854e73
Use SpecialPowers.pushPrefEnv in mail component browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/83c7ce650c47
Use SpecialPowers.pushPrefEnv in WebExtension compose and message-list browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/351d030fce6b
Use SpecialPowers.pushPrefEnv in account and attachment browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/c14b35c4e85c
Use SpecialPowers.pushPrefEnv in composition browser tests. r=aleca

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f56d7174d75d
Use SpecialPowers.pushPrefEnv in folder display browser tests. r=aleca
https://hg.mozilla.org/comm-central/rev/05e9f90fdeb0
Use SpecialPowers.pushPrefEnv in misc mail browser tests. r=mkmelin

Comment 18

[Toby Pilling [:tobyp]]

Attachment: Bug 2066871 - Use SpecialPowers.pushPrefEnv in additional browser tests. r=#thunderbird-reviewers

Comment 19

[Toby Pilling [:tobyp]]

That's it actually. I very much hope!!

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6e230b05d5f
Use SpecialPowers.pushPrefEnv in remaining WebExtension browser tests. r=mkmelin
https://hg.mozilla.org/comm-central/rev/5c0e6a855180
Use SpecialPowers.pushPrefEnv in CloudFile, message reader, and notification browser tests. r=mkmelin
https://hg.mozilla.org/comm-central/rev/2453aa3f68e3
Use SpecialPowers.pushPrefEnv in OpenPGP and S/MIME browser tests. r=mkmelin