198250 - Popup manager is presented inconsistently and different from other managers

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Hanspeter Niederstrasser]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4a) Gecko/20030317
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4a) Gecko/20030317

There are 3 ways to open the popup manager (see below).  The methods produce
inconsistent results, and are also different from how the other managers behave.
 The popup manager should behave the same regardless of how it is called and its
behavior should be the same as the other managers.

Reproducible: Always

Steps to Reproduce:
1. Open the Popup manager from Tools -> Popup Manager -> Manage popup permissions
2. Close popup manager and open the Popup manager from Prefs -> Privacy &
Security -> Popup windows -> Exceptions...
3. Close popup manager and open the Popup manager by clicking the starburst icon
in the status bar

Actual Results:  
For methods 1 and 2, the Popup manager opens as a modal sheet.  With method 3
(status bar icon), the manager opens as a separate dialog window.

Expected Results:  
The popup manager should have opened as a free-standing dialog window by all 3
methods.

All the other managers (forms, images, cookies, password, download) open as a
standalone window.  The popup manager is the only manager that opens as a sheet,
and does so inconsistently.

Comment 1

[Boris Zbarsky [:bzbarsky]]

To shliang

Comment 2

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win95; en-US; rv:1.3) Gecko/20030312]

(Case 1) Confirmed: see also my bug 182359 comment 4.

Suggestions for this bug report:
 *Harware: -> All; OS: -> All.

Moreover, 1 "modal sheet" can be opened for each browser window :-(

PS: There is also bug 195488 about a "bug 182359 like" issue with case 3.

Comment 3

[Serge Gautherie (:sgautherie)]

Based on bug 172537 comment 12,
it could be interesting to fix the current bug "before" bug 192703.

Comment 4

[Serge Gautherie (:sgautherie)]

Replace my comment 3 by the following one:

Based on bug 172537 comment 12,
it could be interesting to fix the current bug "before" bug 158665 (and probably
bug 172537).

Comment 5

[David G King]

As per Comment #2, changing Hardware to ALL and OS to ALL.

I did notice that Mac OS X and Win XP seem to have slightly different wording
for the same functionality. For example Step 1 on Win XP is
Tools-PopupManager-ManagePopups.

Comment 6

[Philip Chee]

None of the three methods produce a modal dialog on trunk. Probably fixed by the rewrite when we moved to toolkit.