2005033 - how to change back to white the background of the sidebar for the bookmarks in Firefox (problem appeared when I updated to v146)

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect)

Description

[michaeljustgreat1]

Attachment: how to change to white the background of the sidebar for the bookmarks in firefox (problem appeared when I updated to v146).jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:146.0) Gecko/20100101 Firefox/146.0

Steps to reproduce:

Just after updating to version 146 of Firefox today, the background of my sidebar at the left for bookmarks (or any of the other options available when clicking on the drop-down menu for bookmarks) changed from being white (perfect for reading these bookmarks) to being sky blue, same color than the rest of my browser (very bad for reading these bookmarks)!!!

Expected results:

After updating to v146, I should have kept having the white background of my sidebar at the left for bookmarks.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Monica Chiorean]

Update should not change the theme, to go back to previous theme select Menu->Extensions&Themes and on new page select the light theme.
Can you please mention if this also happen with a new and empty profile? See https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile Thank you.

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Reopening until we confirm if this is the same issue as bug 2005148

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Could you please also confirm which theme you are using?
Assuming that the theme is Light Blue theme (the colors in the screenshot and description match — sidebar bookmarks background was white before the patch and sky blue after), mozregression points to bug 1984885.

Comment 6

[michaeljustgreat1]

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #5)

Hello! Could you please also confirm which theme you are using?
Assuming that the theme is Light Blue theme (the colors in the screenshot and description match — sidebar bookmarks background was white before the patch and sky blue after), mozregression points to bug 1984885.

Yes, my theme is called Light Blue and you can see it at https://addons.mozilla.org/en-US/firefox/addon/light-blue-cool-colour/

Comment 7

[michaeljustgreat1]

Just by curiosity, I removed my current Light Blue theme and installed several other blue schemes and the same issue persists that is the left sidebar of my bookmarks changes color BUT it is still not a white background for the sidebar of my bookmarks like it is normally by default and previously to updating to version 146.

When I removed the Light blue theme and I do not install a new theme (keeping the default theme that comes with Firefox), I do get back the white background of the sidebar of my bookmarks.

Comment 8

[Kestrel]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f4274c58d4530a2adadb81eaafabf0d8ccead13c&tochange=935a682c44fe2c6737dce0405a52c960eaa698f5

Regressed by Bug 1984885.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1984885, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 2005033 - Reverting Bug 1984885 changes as short term workaround to sidebar colors regression with some third party themes.

This patch is reverting the changes introduced in browser-colors.css and webext-panels.css by Bug 1984885,
it is meant to be a short term workaround to handle the unexpected side-effect on some third party themes
that have been changed behavior in a way that was perceived as a 146 regression by users of some of the
third party themes available on addons.mozilla.org.

As a longer term solution it is not unlikely that Bug 1984885 changes may have to be re-introduced along with
further changes to improve as much as possible the sidebar colors for the existing third party themes
(e.g. along with the additional changes part of the approach being explored in Bug 1952602).

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: screenshot-compare-current-nightly-with-and-without-reverting-patch.png

This attachment is a screenshot demonstrating the effect of the patch with the theme linked in this bug:

• on the left: today's nightly
• on the right: today's nightly with the patch attached to this bug applied (and so with Bug 1984855 changes reverted)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/34025655dfca
https://hg.mozilla.org/integration/autoland/rev/b45caaa19b59
Reverting Bug 1984885 changes as short term workaround to sidebar colors regression with some third party themes. r=jsudiaman

Comment 13

[William Durand [:willdurand]]

Comment on attachment 9534223 [details]
Bug 2005033 - Reverting Bug 1984885 changes as short term workaround to sidebar colors regression with some third party themes.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: There is a relatively bad UI regression related to themes, contrasts, and background images, which was apparently introduced in 146. The number of affected users is unknown but since that impacts themes and we got a few reports already, the number of users impacted might be substantial.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch reverts a patch landed in 146. The patch was fixing a defect but in retrospect, it looked more like an improvement, which is why it makes it safe to revert, and why it makes this uplift request not risky.
• String changes made/needed:
• Is Android affected?: No

Comment 14

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b45caaa19b59

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9534223 [details]
Bug 2005033 - Reverting Bug 1984885 changes as short term workaround to sidebar colors regression with some third party themes.

Approved for 147.0b8.

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/999b1c61769b
https://hg.mozilla.org/releases/mozilla-beta/rev/c1a0bd9e9c26

Comment 20

[michaeljustgreat1]

Contrary to Mark Striemer claims, I do not believe that it would be a duplicate of bug 2007168. Because my blue background in the bookmarks sidebar at the left is not linked to having a light or dark background.

Comment 21

[michaeljustgreat1]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #17)

Comment on attachment 9534223 [details]
Bug 2005033 - Reverting Bug 1984885 changes as short term workaround to sidebar colors regression with some third party themes.

Approved for 147.0b8.

I am happy to confirm that this BUG has now been corrected with the version 147 of Firefox. Thanks to the developers who sorted out this BUG.
With version 147, the background of my sidebar at the left for bookmarks (or any of the other options available when clicking on the drop-down menu for bookmarks) has now been changed to how it was by default before, that is it is now white (perfect for reading these bookmarks).
Thanks.