1987759 - Startup Crash [@ nsMsgFilter::GetNeedsMessageBody ]

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Magnus Melin [:mkmelin] (away until July 8)]

Crash at [@ nsMsgFilter::GetNeedsMessageBody ] - like bp-adc9cdf0-0ebe-47d8-923e-8c09a0250909 - xref bug 1976182 comment 19

Comment 1

[Magnus Melin [:mkmelin] (away until July 8)]

Attachment: Bug 1987759 - Fix crash [@ nsMsgFilter::GetNeedsMessageBody ]. r=#thunderbird-back-end-reviewers

https://searchfox.org/comm-central/rev/ddf2f4c45cede0aaab17c48962a320af37bf7363/mailnews/search/src/nsMsgFilterService.cpp#1071

Comment 2

[Wayne Mery (:wsmwk)]

Crash report: https://crash-stats.mozilla.org/report/index/adc9cdf0-0ebe-47d8-923e-8c09a0250909

Reason:

SIGSEGV / SEGV_MAPERR

Top 10 frames:

0  libxul.so  nsMsgFilter::GetNeedsMessageBody(bool*)  mailnews/search/src/nsMsgFilter.cpp:614
1  libxul.so  nsMsgFilterList::DoFiltersNeedMessageBody(int, bool*)  mailnews/search/src/nsMsgFilterList.cpp:1217
2  libxul.so  nsImapMailFolder::UpdateFolderWithListener(nsIMsgWindow*, nsIUrlListener*)  mailnews/imap/src/nsImapMailFolder.cpp:649
3  libxul.so  nsImapMailFolder::GetNewMessages(nsIMsgWindow*, nsIUrlListener*)  mailnews/imap/src/nsImapMailFolder.cpp:2322
4  libxul.so  nsImapIncomingServer::PerformBiff(nsIMsgWindow*)  mailnews/imap/src/nsImapIncomingServer.cpp:875
5  libxul.so  NS_InvokeByIndex
6  libxul.so  CallMethodHelper::Invoke()  js/xpconnect/src/XPCWrappedNative.cpp:1620
6  libxul.so  CallMethodHelper::Call()  js/xpconnect/src/XPCWrappedNative.cpp:1174
6  libxul.so  XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode)  js/xpconnect/src/XPCWrappedNative.cpp:1120
7  libxul.so  XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*)  js/xpconnect/src/XPCWrappedNativeJSOps.cpp:966

First crash is bp-396a631e-6aa8-4eff-8b87-bce1c0250807 2025-08-07 Thunderbird 143.0a1 20250807101307
Most uptime are <= 6 seconds.

So not a regression?

There are more crash signatures with nsImapMailFolder::UpdateFolderWithListener on the stack:

• [OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters}(https://crash-stats.mozilla.org/signature/?proto_signature=~nsImapMailFolder%3A%3AUpdateFolderWithListener&product=Thunderbird&date=%3E%3D2025-03-09T20%3A11%3A00.000Z&date=%3C2025-09-09T20%3A11%3A00.000Z&_sort=-date&signature=OOM%20%7C%20large%20%7C%20NS_ABORT_OOM%20%7C%20nsMsgFilterList%3A%3ALoadTextFilters) also all startup presumed fixed in 143 by Bug 1980814 - Startup Crash in [@ OOM | large | NS_ABORT_OOM | nsMsgFilterList::LoadTextFilters] (we won't know for a few more weeks)
• and nsImapProtocol::SetupWithUrl

Comment 3

[Magnus Melin [:mkmelin] (away until July 8)]

Ah, it's a regression from bug 1975717
https://hg-edge.mozilla.org/comm-central/rev/71c3d475249c#l1.83

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcacd1a59c6d
Fix crash [@ nsMsgFilter::GetNeedsMessageBody ]. r=tobyp

Comment 5

[Magnus Melin [:mkmelin] (away until July 8)]

Comment on attachment 9512369 [details]
Bug 1987759 - Fix crash [@ nsMsgFilter::GetNeedsMessageBody ]. r=#thunderbird-back-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Crash, regression
• User impact if declined: May crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Null check
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 6

[Corey Bryant]

Comment on attachment 9512369 [details]
Bug 1987759 - Fix crash [@ nsMsgFilter::GetNeedsMessageBody ]. r=#thunderbird-back-end-reviewers

[Triage Comment]
This was included in this week's merge of cc->beta

Comment 7

[Corey Bryant]

This crash is no longer showing up for 144.0b1. Want to uplift to 143.0.1 (Sep 30)?

Comment 8

[Corey Bryant]

Actually let's cut a point release today instead of waiting. This affects approximately .45% of users and they don't appear to have a work-around.

Comment 9

[Corey Bryant]

Comment on attachment 9512369 [details]
Bug 1987759 - Fix crash [@ nsMsgFilter::GetNeedsMessageBody ]. r=#thunderbird-back-end-reviewers

[Triage Comment]
Approved for release

Comment 10

[Corey Bryant]

Thunderbird 143.0.1:
https://hg.mozilla.org/releases/comm-release/rev/2608cfda9ffa