1988993 - Unsafe async activity usage in PlayStoreReviewPromptController.tryLaunchPlayStoreReview

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, defect)

Description

[Marcin Koziński]

In tryPromptReview the activity passed in is used in the async manager.addOnCompleteListener. This means we might be holding onto the activity and try to use it after it was destroyed.

Comment 1

[Marcin Koziński]

Attachment: Bug 1988993 - Scope listener to activity, to remove it during onStop

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c139392fab8a
https://hg.mozilla.org/integration/autoland/rev/a1a5e279ba84
Scope listener to activity, to remove it during onStop r=android-reviewers,twhite,jonalmeida

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a1a5e279ba84

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5db4b7f0be02
https://hg.mozilla.org/mozilla-central/rev/f17c7e0fde9f
Revert "Bug 1988993 - Scope listener to activity, to remove it during onStop r=android-reviewers,twhite,jonalmeida" for causing conflict on bug 1986398

Comment 5

[Cristina Horotan [:chorotan]]

Backed out from central for causing conflict on the backout of Bug 1986398
https://hg.mozilla.org/mozilla-central/rev/f17c7e0fde9ffd96c7a9845b6d213f655205d8f5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b122b69bb68c
https://hg.mozilla.org/integration/autoland/rev/82e7f69975e4
Scope listener to activity, to remove it during onStop r=android-reviewers,twhite,jonalmeida

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:towhite, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/82e7f69975e4