1989529 - Add missing tests for PlayStoreReviewPromptController

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Marcin Koziński]

PlayStoreReviewPromptController started by extracting existing logic from ReviewPromptController that didn't have any existing tests. As we continue to add features to it and fix bugs in it, it's high time to fill the void.

Comment 1

[Marcin Koziński]

Attachment: Bug 1989529 - Add missing tests for PlayStoreReviewPromptController

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/063e448b4e8a
https://hg.mozilla.org/integration/autoland/rev/daf37be46672
Add missing tests for PlayStoreReviewPromptController r=android-reviewers,gmalekpour

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/daf37be46672

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4e86781dadc2
https://hg.mozilla.org/integration/autoland/rev/b7bdaec18d79
Revert "Bug 1989529 - Add missing tests for PlayStoreReviewPromptController r=android-reviewers,gmalekpour" for causing perma failure on PlayStoreReviewPromptControllerTest

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing perma fail after Bug 1986398 and Bug 1988993 were backed out here

Failure log: https://treeherder.mozilla.org/logviewer?job_id=530199976&repo=mozilla-central&task=QJr0M4myQ-WhqvVOeYrySQ.0&lineNumber=8856

Comment 6

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg-edge.mozilla.org/mozilla-central/rev/b7bdaec18d79

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a17801329eed
https://hg.mozilla.org/integration/autoland/rev/86320e5ee485
Add missing tests for PlayStoreReviewPromptController r=android-reviewers,gmalekpour

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/86320e5ee485