199364 - Bookmarks drag and drop in the personal toolbar is broken

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030325
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4a) Gecko/20030325

Just try it...

Reproducible: Always

Steps to Reproduce:
1. Drag a bookmark in the personal toolbar to another place in the personal toolbar

Actual Results:  
Although mouse cursor etc. look like it should work the bookmark is not moved
but stays where it was.

Expected Results:  
The bookmark should've been moved to where I dropped it.

Moving from PT to places in a "manage bookmarks" window works, but *not* the
other way. So mainly _dropping_ on the PT seems broken.
All I said is not only valid for bookmarks directly in the PT, but also in
subfolders.
This used to work before the bookmark branch landed.

Comment 1

[Andreas Kunz]

cc'ing Jan Varga (bookmark branch guy) and marking as regression.

Comment 2

[Jan Varga [:janv]]

-> me

Comment 3

[Hermann Schwab]

If you want to change positions of folders in the Personal Toolbar, you can do
it by moving the folders in the Manage Bookmarks Window.
But the M.B.-Window doesn´t show the correct sequence of folders in the P.T.
My P.T. has 1 unvisible folder, at the right, because it was at the right,
before I inserted one more folder in the toolbar.
M.B.Window shows the left..to..right folders of P.T. top-down, with one exception:
Top Folder should be Left Folder, Bottom Folder should be Right folder, but it
is the other way, Leftmost folder is displayed at bottom, Rightmost(invisible)
folder is displayed at top.
I can move bookmarks in M.B.Window, and that move is shown in P.T., but not in
M.B.W., in MBW it is shown only after closing and reopening MBW.

Comment 4

[Andreas Kunz]

Hermann, I never spoke about changing positions of folders.

Comment 5

[Andreas Kunz]

When I said that "mainly _dropping_ on the PT seems broken", this was wrong:
dropping the URLbar URL icon to the personal toolbar works as does dnd'ing links
from webpages.

Comment 6

[Koike Kazuhiko]

If you add a lot of bookmarks on the personal toolbar, ">>" appears at the right
edge.
Clicking it shows the overflowed bookmarks. But they can't be moved to an another
position on the personal toolbar by D&D.

Comment 7

[Andreas Kunz]

Umm... now this works for me with 2003032508 and CVS build 20032701.
With all profiles I might have used when I reported the bug.

Can anybody please try to reproduce?

I can, however, confirm comment #6. 

Comment 8

[Chris Petersen]

This seems to work for me in the win32 build (2003-04-01-08). Using a new
profile, I can rearrange my existing bookmarks (via drag n drop) on the personal
toolbar. Tested under Win Xp with Modern theme.

Comment 9

[Chris Petersen]

Ok, I can reproduce this problem only when I have created a new browser window
(rather that using the default window that opens at startup)

1) Launch Mozilla (Modern theme)
2) Verify with the default browser window that opens, you can succuesfully a
drag proxy url to personal toolbar. You can rearrange or even delete bookmarks
from the toolbar on this window.
3) Now, create a new window.
4) Using this second window, you CAN'T delete, rearange, or add links or proxy
urls to the personal toolbar....

Comment 10

[Andreas Kunz]

Yes, Chris, thank you: this way I can finally reproduce this again (CVS build,
Win2k).

One important detail: if you don't do step 2) then it will still work in the
second window!
So you may open as many windows as you want after starting Mozilla and then try
in any one of them, it will work.
BUT it will not work in any window you open after you tried this for the first
time. So the first drag and drop action seems to trigger this bug for all
windows opened afterwards. New steps to reproduce:

1) Start Mozilla and do anything including opening windows but do not drag and
drop in the PT.
2) Then do a drag and drop in the PT: it will work (in all windows open at that
point of time).
3) Open any number of new windows: it will be broken there.

Jan, might this help?

Comment 11

[Rafael Ebron (:rebron)]

navtriage: nsbeta1+/adt3

Comment 12

[Pierre Chanial]

The real fix for it is to make the bookmark transaction manager instance a
global var (in nsBookmarksService.cpp)

Comment 13

[Jan Varga [:janv]]

Pierre, thanks for the hint.

Comment 14

[Jan Varga [:janv]]

fixed along with bug 201013

Comment 15

[Andreas Kunz]

*** Bug 200643 has been marked as a duplicate of this bug. ***

Comment 16

[Chris Petersen]

Verified on the 2003-04-22-08 Macho and Win32 trunk builds.