1996152 - Update enterprise policies documentation for the new `browser.urlbar.suggest.quicksuggest.all` pref

Status: ASSIGNED

(Firefox :: Enterprise Policies, task, P1)

Description

[Drew Willcoxon :adw]

Update browser/components/enterprisepolicies/Policies.sys.mjs and its test for the new browser.urlbar.suggest.quicksuggest.all pref being added in bug 1995574. See this patch as an example: https://phabricator.services.mozilla.com/D269324

Based on what Mike said in that revision, we need to keep the existing WebSuggestions pref so existing consumers aren't broken. In fact we probably don't need to introduce a new policy name at all, just update WebSuggestions so it uses the new pref, although I defer to Mike on that -- might not be a good idea after all since previously if a consumer set WebSuggestions to false, it would only disable nonsponsored, but now it would disable nonsponsored and sponsored.

Comment 1

[Mark Banner (:standard8)]

(In reply to Drew Willcoxon :adw from comment #0)

Based on what Mike said in that revision, we need to keep the existing WebSuggestions pref so existing consumers aren't broken. In fact we probably don't need to introduce a new policy name at all, just update WebSuggestions so it uses the new pref, although I defer to Mike on that -- might not be a good idea after all since previously if a consumer set WebSuggestions to false, it would only disable nonsponsored, but now it would disable nonsponsored and sponsored.

Mike, do you have a sense of what we want to do here?

Bug 1995577 will be changing the pref that WebSuggestions is linked to so that tests keep passing, but we might still want to add a new policy here.

Comment 2

[Mike Kaply [:mkaply]]

So there isn't going to be a way to separate sponsored and no sponsored suggestions anymore? Not sure I understand.

What's happening with

browser.urlbar.suggest.searches and browser.search.suggest.enabled?

We have a separate policy for overall search suggestions

https://mozilla.github.io/policy-templates/#searchsuggestenabled

Comment 3

[Mark Banner (:standard8)]

(In reply to Mike Kaply [:mkaply] from comment #2)

So there isn't going to be a way to separate sponsored and no sponsored suggestions anymore? Not sure I understand.

The current non-sponsored option for quick suggest is being replaced by an "all". Sponsored will still remain, but if "all" is off, then you won't be able to get sponsored results.

Comment 4

[Mike Kaply [:mkaply]]

I think this is fine. We'll just update the docs and reuse WebSuggestions. And deprecate ImproveSuggest?

For some reason I never documented this here:

https://mozilla.github.io/policy-templates/#firefoxsuggest

The only documentation is in the ADMX:

Suggestions from the web (WebSuggestions)
If this policy is enabled, you will get suggestions from Firefox related to your search.

If this policy is disabled, you will not get these suggestions.

If this policy is not configured, you will get suggestions from Firefox related to your search.

Suggestions from sponsors (SponsoredSuggestions)
If this policy is enabled, you will support the development of Firefox with occasional sponsored suggestions.

If this policy is disabled, you will not get these suggestions.

If this policy is not configured, you will get occasional sponsored suggestions.

Improve the Firefox Suggest experience (ImproveSuggest)
If this policy is enabled, you will help create a richer search experience by allowing Mozilla to process your search queries.

If this policy is disabled or not configured, you do not allow Mozilla to process your search queries.

Comment 5

[Drew Willcoxon :adw]

We handled ImproveSuggest in D269324.

Comment 6

[Mark Banner (:standard8)]

Hi Mike, with the landing of bug 1995577, I think we should be good, but we'll need the documentation updating. Would you be able to update it for us?

In case it isn't clear, the WebSuggestions option will now control all suggestions - so if it is disabled, SponsoredSuggestions and the new OnlineEnabled will not do anything.

Comment 7

[Mike Kaply [:mkaply]]

Yep, I have it on list of things to update in policy when we get to release.

Comment 8

[Drew Willcoxon :adw]

Thanks Mike, it sounds like all we need to do here is update documentation, so I'll assign this to you. (I'm triaging remaining blockers for bug 1995336.) I'm not sure we need to keep this open at all but I'll leave that up to you.