1995583 - Test manifest cleanup

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Tom Marble]

Fall cleaning for test manifests to harmonize on currently used platforms and conventions

Remove linux os_version=="18.04" from *.toml
https://searchfox.org/firefox-main/search?q=os_version+%3D%3D+%2718.04%27&path=*.toml&case=false&regexp=false

If os == "linux" and no version, add os_version == '24.04' && display == 'x11', and verify on try, specifically linux2204 wayland
https://searchfox.org/firefox-main/search?q=%5E.*os+%3D%3D+%27linux%27%5B%5Ev%5D*%24&path=*.toml&case=false&regexp=true

Change processor -> arch in most/all places
https://searchfox.org/firefox-main/search?q=processor&path=*.toml&case=false&regexp=true

Remove bits
bits == '64' => x86_64 or aarch64
bits == '32' => x86
https://searchfox.org/firefox-main/search?q=bits&path=*.toml&case=false&regexp=true

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

also macosx osversion == 11.20, we don't run there anymore, that was replaced with 15.30.

Comment 2

[Tom Marble]

Attachment: Bug 1995583 - test manifest cleanup for idiomatic usage r=jmaher

For TOML manifests:

1. Change processor -> arch
2. Use arch instead of bits
   bits == '64' => aarch64 (default on mac) or x86_64
   bits == '32' => x86
3. Replace android_version with corresponding os_version
4. Remove conditions with linux os_version=="18.04"
   (unless they contain verify or verify-standalone)
5. Remove conditions with mac os_version=='11.20',
   (unless they contain verify or verify-standalone)
6. Linux conditions should have os_version, arch and display

Resolves 2000285

Signed-off-by: Tom Marble <[e-mail]>

Comment 3

[Tom Marble]

Resolves 2000285

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5ce09d7446f4
https://hg.mozilla.org/integration/autoland/rev/eed43fae866e
test manifest cleanup for idiomatic usage r=jmaher,necko-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,media-playback-reviewers,sessionstore-reviewers,tabbrowser-reviewers,translations-reviewers,omc-reviewers,browser-installer-reviewers,twisniewski,masayuki,dom-core,smaug,nalexander,emcminn,sthompson,alwu,ai-ondevice-reviewers,valentin

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eed43fae866e

Comment 6

[Chris H-C :chutten]

Was it intended that this inverted the skip condition on t/c/glean/xpcshell's test_MillionQ.js?

It went from

["test_MillionQ.js"]
skip-if = [
  "os == 'android'", # Android inits its own FOG, so the test won't work.
  "appname == 'thunderbird'" # interesting_serverknobs.json isn't applied before init.
]

to

["test_MillionQ.js"]
run-if = [
  "appname != 'thunderbird'", # interesting_serverknobs.json isn't applied before init.
]
skip-if = [
  "os != 'android'", # Android inits its own FOG, so the test won't work.
]

...Also, is "!appname == 'thunderbird'" a valid form? That got put in there too.

Comment 7

[Tom Marble]

(In reply to Chris H-C :chutten from comment #6)

Was it intended that this inverted the skip condition on t/c/glean/xpcshell's test_MillionQ.js?

Yes. The goal is to use run-if to specify which are the intended platforms for a test to run
(and the logic to run is inverted from the logic to skip.

...Also, is "!appname == 'thunderbird'" a valid form? That got put in there too.

Oops! No that's a typo. I'll fix it in a patch I'm working on.

Comment 8

[Chris H-C :chutten]

Oh, I understand that much. But it went from skip-if to... still skip-if, but inverted the condition. That seems like a bug?

Comment 9

[Tom Marble]

So many pronouns! I think you mean I inverted os == android in the skip-if ???
That was a bug! I'll fix that too!

https://hg-edge.mozilla.org/mozilla-central/diff/eed43fae866eaebbfa3d2e77e0ed3e92c17af6bd/toolkit/components/glean/tests/xpcshell/xpcshell.toml#l1.67