1997192 - Enable JS MicroTaskQueue by default

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1997192 - Enable JS MicroTaskQueue by default r?smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7a098a77b3e
https://hg.mozilla.org/integration/autoland/rev/13d65a94e4cf
Enable JS MicroTaskQueue by default r=smaug

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/13d65a94e4cf

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5cd6bc910b97
https://hg.mozilla.org/integration/autoland/rev/4c34172a4f7e
Revert "Bug 1997192 - Enable JS MicroTaskQueue by default r=smaug" for causing performance regressions

Comment 5

[amarc]

Backed out for causing performance regressions: https://hg.mozilla.org/integration/autoland/rev/4c34172a4f7e

Comment 6

[amarc]

Relanded because it was causing SM bustages -> https://treeherder.mozilla.org/logviewer?job_id=536572769&repo=autoland&task=aj4x0WTsT2a33s_rsS9hZw.0&lineNumber=56420

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea827274b43d
https://hg.mozilla.org/integration/autoland/rev/738f0baebdd8
Enable JS MicroTaskQueue by default r=smaug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0670784eadcf
https://hg.mozilla.org/integration/autoland/rev/208f4bfe9de0
Revert "Bug 1997192 - Enable JS MicroTaskQueue by default r=smaug" for causing performance regressions.

Comment 9

[Florin Bilt]

(In reply to amarc from comment #5)

Backed out for causing performance regressions: https://hg.mozilla.org/integration/autoland/rev/4c34172a4f7e

Perfherder has detected a devtools performance change from push 4c34172a4f7eb469cd5ba2348c290e5455de6d7e.

No action is required from the author; this comment is provided for informational purposes only.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	damp custom.jsdebugger.stepIn.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,859.89 -> 2,948.97
3%	damp custom.jsdebugger.stepIn.big-bundle.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	1,345.33 -> 1,386.22
3%	damp custom.jsdebugger.stepInNewSource.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	833.55 -> 855.70
3%	damp custom.jsdebugger.stepIn.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	1,270.83 -> 1,303.31

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
8%	damp jstracer.profiler-recording-performance.DAMP	windows11-64-24h2-shippable	e10s fission stylo webrender	151.24 -> 139.85
7%	damp jstracer.profiler-recording-performance.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	574.26 -> 531.96

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4c000c7022cf
https://hg.mozilla.org/integration/autoland/rev/b3b781fc45ba
Enable JS MicroTaskQueue by default r=smaug

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/69ce3c1b9faf
https://hg.mozilla.org/integration/autoland/rev/fca2f5e043d7
Revert "Bug 1997192, Bug 2002876, Bug 2002035, Bug 2002849 - Enable JS MicroTaskQueue by default r=smaug" for causing xpc failures at test_promise_job_across_sandbox.js.

Comment 12

[Atila Butkovits]

Backed out for causing xpc failures at test_promise_job_across_sandbox.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/fca2f5e043d75fca3c591850e7822510fd6f1b5d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b3b781fc45ba215f17c601666ab03f3a3b76d1f9&selectedTaskRun=YjGfiVt_SnWCHKuo83khuw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=537842962&repo=autoland&task=YjGfiVt_SnWCHKuo83khuw.0&lineNumber=2679

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3cf7d867803e
https://hg.mozilla.org/integration/autoland/rev/f564813850eb
Enable JS MicroTaskQueue by default r=smaug

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f564813850eb

Comment 15

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #7)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea827274b43d
https://hg.mozilla.org/integration/autoland/rev/738f0baebdd8
Enable JS MicroTaskQueue by default r=smaug

Perfherder has detected a browsertime performance change from push 738f0baebdd8410eb67f13683205d65d78f22fb2.

No action is required from the author; this comment is provided for informational purposes only. The changes have already been reverted.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
13%	jetstream3 doxbee-promise-Geometric	macosx1500-aarch64-shippable	fission webrender	51.97 -> 45.10	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 16

[Florin Bilt]

(In reply to amarc from comment #5)

Backed out for causing performance regressions: https://hg.mozilla.org/integration/autoland/rev/4c34172a4f7e

Perfherder has detected a browsertime performance change from push 4c34172a4f7eb469cd5ba2348c290e5455de6d7e.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
13%	jetstream3 doxbee-promise-Average	macosx1500-aarch64-shippable	fission webrender	99.65 -> 86.55	Before/After
10%	jetstream3 doxbee-promise-Average	windows11-64-24h2-shippable	fission webrender	142.56 -> 128.98	Before/After
9%	jetstream3 doxbee-async-Average	macosx1500-aarch64-shippable	fission webrender	48.01 -> 43.88	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 17

[Iain Ireland [:iain]]

I was confused by the reported numbers until I realized that the regression is from the initial landing two weeks ago, and the improvement is from backing it out. Neither of these automated reports has any bearing on the improvement from the latest version to land.

It looks like the latest version improves our score from ~50 to ~75.

Comment 18

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #8)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0670784eadcf
https://hg.mozilla.org/integration/autoland/rev/208f4bfe9de0
Revert "Bug 1997192 - Enable JS MicroTaskQueue by default r=smaug" for
causing performance regressions.

Perfherder has detected a browsertime performance change.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
13%	jetstream3 doxbee-promise-Average	macosx1500-aarch64-shippable	fission webrender	99.67 -> 86.82	Before/After
10%	jetstream3 doxbee-async-Average	macosx1500-aarch64-shippable	fission webrender	48.29 -> 43.60	Before/After
7%	jetstream3 doxbee-promise-Average	android-hw-a55-14-0-aarch64-shippable	webrender	340.43 -> 317.27
7%	jetstream3 doxbee-promise-Worst	android-hw-a55-14-0-aarch64-shippable	fission webrender	416.31 -> 388.12
7%	jetstream3 doxbee-promise-Average	android-hw-a55-14-0-aarch64-shippable	fission webrender	339.75 -> 317.37
...	...	...	...	...	...
5%	jetstream3 async-fs-Average	android-hw-a55-14-0-aarch64-shippable	fission webrender	50.38 -> 47.85

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 19

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #13)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3cf7d867803e
https://hg.mozilla.org/integration/autoland/rev/f564813850eb
Enable JS MicroTaskQueue by default r=smaug

Perfherder has detected a browsertime performance change from push f564813850eb211c9b5e05ee5349b5584d877ce4.

No action is required from the author; this comment is provided for informational purposes only.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
49%	jetstream3 doxbee-promise-Geometric	android-hw-a55-14-0-aarch64-shippable	fission webrender	14.60 -> 21.75
49%	jetstream3 doxbee-promise-Geometric	windows11-64-24h2-shippable	fission webrender	34.18 -> 50.91
47%	jetstream3 doxbee-promise-Geometric	android-hw-a55-14-0-aarch64-shippable	webrender	14.73 -> 21.71
46%	jetstream3 doxbee-async-Geometric	android-hw-a55-14-0-aarch64-shippable	fission webrender	26.36 -> 38.43
38%	jetstream3 doxbee-async-Geometric	android-hw-a55-14-0-aarch64-shippable	webrender	26.97 -> 37.15
...	...	...	...	...	...
7%	jetstream3 async-fs-Average	macosx1500-aarch64-shippable	fission webrender	12.60 -> 11.74	Before/After

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.