1999082 - "Exchange Auth Error" adding outlook.com in Account Hub

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect, P1)

Description

[[:Lorenzo27]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:144.0) Gecko/20100101 Firefox/144.0

Steps to reproduce:

Try setting an outlook.com account using Account Hub, login when the Microsoft page opens.

Actual results:

This is where other accounts using OAuth authentication show the servers for Imap and Pop but with outlook.com Thunderbird ignores the first login and shows a login page inside the Account Hub asking for Password in TB 144.0.1, and for Password and "Your login" in TB 145.0b4.
Even if the credentials are correct the second login fails (maybe because there is also 2FA that it doesn't ask) and you can't add the account.

The Error Console shows this:
...
mail.setup: Account setup error: Exchange auth error. undefined Error: Exchange auth error
AuthenticationRequiredError chrome://messenger/content/accountcreation/views/email.mjs:42
#findConfig chrome://messenger/content/accountcreation/views/email.mjs:1045
Caused by: Object { … }
account-hub-header.mjs:96:27
...

If I disable Account Hub and try to add the same account with the old procedure it doesn't ask for a password and doesn't show the Microsoft login page, it just uses the token generated previously in the Account Hub and the account works.

Expected results:

Account Hub shouldn't ask for password when the login is made in the Microsoft page.

The same issue was reported in the Italian Forum, I used a new profile for the test.

I don't know if this is related to Bug 1975721 but it seems a little different to me.

Comment 1

[Wayne Mery (:wsmwk)]

I don't know if this is related to Bug 1975721 but it seems a little different to me.

That was linked to Bug 1957591 - account hub: Exchange discovery needs password - which was fixed in version 142.

Comment 2

[Martin Giger [:freaktechnik]]

I think this is caused by how we handle Exchange Autodiscover failures. In the old setup we'd only care about autodiscover failing, if we didn't find a valid IMAP config. In account hub's code (FindConfig.sys.mjs) we treat failures in the exchange autodiscover process as fatal and will always fail the entire process, no matter what we found through conventional methods. We should adjust the handling of the Exchange Autodiscover search in Account Hub to be more lenient.

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1999082 - Fix setting up outlook.com accounts in account hub. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a581ee1ad78
Fix setting up outlook.com accounts in account hub. r=edicharry

Comment 5

[Wayne Mery (:wsmwk)]

Given P1+S2, should we uplift to beta to get this shipped in 150?

Comment 6

[Martin Giger [:freaktechnik]]

I don't think P1 is any indicator, it's purely a planning value. The reason I'm hesitating is that the change is fairly complex and still very recent. On the other hand we're currently still fairly fresh in the beta cycle.

Comment 7

[Magnus Melin [:mkmelin] (away until Aug 10)]

We're actually at the very end of the beta cycle. Next cycle starts next week.