2003298 - Stop using nsISearchEngine in search service notifications

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We are working towards removing the nsI* interfaces relating to the search service (bug 1643008).

As part of this, we can't continue to use the nsIObserverService as that would require data items to still at least use nsISupports. Therefore we should replace the observer service usages with EventEmitter.

Comment 1

[Moritz Beier [:mbeier]]

Using EventEmitter requires all consumers to import the search service JS module which would cause it to be loaded much earlier.
To prevent this, we decided to keep using the observer service but without nsISearchEngine by accessing wrappedJSObject instead.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2003298 - Stop using nsISearchEngine in search service notifications. r?standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7ba6c87e65a
https://hg.mozilla.org/integration/autoland/rev/87b1fe3f453d
Stop using nsISearchEngine in search service notifications. r=Standard8,urlbar-reviewers,toolkit-telemetry-reviewers,mstriemer

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/87b1fe3f453d