2003300 - Remove the nsI* interfaces relating to the search service

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Once bug 2003298 is complete, we should be in a position to remove the nsISearchService and nsISearchEngine definitions.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Remove now unused SearchUtils.DEFAULT_TAG. r?#search-reviewers!

We stopped using this when we moved away from configuration search engines being backed by WebExtensions.

Depends on D277329

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Move test-only SearchUtils.ENGINES_URLS from production code into tests. r?#search-reviewers!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Remove some nsISearchService interface references in the search code. r?#search-reviewers!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Remove nsISearchParseSubmissionResult. r?#search-reviewers!

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Replace nsISearchService.CHANGE_REASON* with SearchService.CHANGE_REASON*. r?#search-reviewers!

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Replace nsISearchService.OpenSearchInstallErrors with a custom Error class. r?#search-reviewers!

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Remove the nsISearchEngine interface. r?#search-reviewers!

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 2003300 - Replace nsISearchSubmission with direct return results. r?#search-reviewers!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/392f4135b823
https://hg.mozilla.org/integration/autoland/rev/5941b1ba40fa
Remove now unused SearchUtils.DEFAULT_TAG. r=search-reviewers,jteow
https://github.com/mozilla-firefox/firefox/commit/b80d0cbe216a
https://hg.mozilla.org/integration/autoland/rev/3cab547a461a
Move test-only SearchUtils.ENGINES_URLS from production code into tests. r=search-reviewers,jteow
https://github.com/mozilla-firefox/firefox/commit/be13c8c425e0
https://hg.mozilla.org/integration/autoland/rev/7c89b6fdc2df
Remove some nsISearchService interface references in the search code. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/cef9562c5d1f
https://hg.mozilla.org/integration/autoland/rev/a06640345d27
Remove nsISearchParseSubmissionResult. r=search-reviewers,scunnane

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5941b1ba40fa
https://hg.mozilla.org/mozilla-central/rev/3cab547a461a
https://hg.mozilla.org/mozilla-central/rev/7c89b6fdc2df
https://hg.mozilla.org/mozilla-central/rev/a06640345d27

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aa1b59ac6a22
https://hg.mozilla.org/integration/autoland/rev/3e6cdeedaa83
Replace nsISearchService.CHANGE_REASON* with SearchService.CHANGE_REASON*. r=search-reviewers,omc-reviewers,urlbar-reviewers,toolkit-telemetry-reviewers,mstriemer,aminomancer,mcheang,jteow
https://github.com/mozilla-firefox/firefox/commit/dfbf2a86120e
https://hg.mozilla.org/integration/autoland/rev/9e06e9774b69
Replace nsISearchService.OpenSearchInstallErrors with a custom Error class. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/ab85ce0e1874
https://hg.mozilla.org/integration/autoland/rev/9b5497ed735e
Remove the nsISearchEngine interface. r=search-reviewers,urlbar-reviewers,mstriemer,mcheang,jteow
https://github.com/mozilla-firefox/firefox/commit/d3e95fee1265
https://hg.mozilla.org/integration/autoland/rev/678337bb3e60
Replace nsISearchSubmission with direct return results. r=search-reviewers,scunnane

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3e6cdeedaa83
https://hg.mozilla.org/mozilla-central/rev/9e06e9774b69
https://hg.mozilla.org/mozilla-central/rev/9b5497ed735e
https://hg.mozilla.org/mozilla-central/rev/678337bb3e60