2003302 - Clean up Search Service code after removing the interfaces

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

Once bug 2003300 is complete, we should review the search service & related code for anything else we can cleanup.

For example, bug 2000685 is adding a wrappedJSObject function to ease the transition, and that should be removed here.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Remove now unnecessary 'ss' aliases to SearchService in test_settings.js. r?#search-reviewers!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Remove SearchService.wrappedJSObject. r?#search-reviewers!

This is no longer necessary now we have removed the xpcom interfaces

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Formally expose the extension ID on AddonSearchEngine. r?#search-reviewers!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Remove SearchEngine.wrappedJSObject. r?#search-reviewers!

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Change SearchService._searchDefault to be a private member. r?#search-reviewers!

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Change SearchService._maybeReloadEngines to be a private member. r?#search-reviewers!

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Change a couple more underscore functions to private in SearchService.sys.mjs. r?#search-reviewers!

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 2003302 - Replace instances of Components.Exception with Error in search code. r?#search-reviewers!

These are no longer necessary now that we are not using XPCOM components.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c8c7d13756fb
https://hg.mozilla.org/integration/autoland/rev/acf6a4cf2191
Remove now unnecessary 'ss' aliases to SearchService in test_settings.js. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/9230d22b8db2
https://hg.mozilla.org/integration/autoland/rev/5db95e9209ab
Remove SearchService.wrappedJSObject. r=search-reviewers,toolkit-telemetry-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/8f5690232d14
https://hg.mozilla.org/integration/autoland/rev/eb073a88d52a
Formally expose the extension ID on AddonSearchEngine. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/7bde16203159
https://hg.mozilla.org/integration/autoland/rev/b0af18489884
Remove SearchEngine.wrappedJSObject. r=search-reviewers,omc-reviewers,mconley,scunnane,emcminn
https://github.com/mozilla-firefox/firefox/commit/29f4cd3eb880
https://hg.mozilla.org/integration/autoland/rev/2cb7200e75b8
Change SearchService._searchDefault to be a private member. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/a80c54c2f3f6
https://hg.mozilla.org/integration/autoland/rev/4957358fe43b
Change SearchService._maybeReloadEngines to be a private member. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/e9c43cfe2e8d
https://hg.mozilla.org/integration/autoland/rev/5ee544215cbf
Change a couple more underscore functions to private in SearchService.sys.mjs. r=search-reviewers,scunnane
https://github.com/mozilla-firefox/firefox/commit/b223f61bc8b0
https://hg.mozilla.org/integration/autoland/rev/55511359439c
Replace instances of Components.Exception with Error in search code. r=search-reviewers,scunnane

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/acf6a4cf2191
https://hg.mozilla.org/mozilla-central/rev/5db95e9209ab
https://hg.mozilla.org/mozilla-central/rev/eb073a88d52a
https://hg.mozilla.org/mozilla-central/rev/b0af18489884
https://hg.mozilla.org/mozilla-central/rev/2cb7200e75b8
https://hg.mozilla.org/mozilla-central/rev/4957358fe43b
https://hg.mozilla.org/mozilla-central/rev/5ee544215cbf
https://hg.mozilla.org/mozilla-central/rev/55511359439c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/73e5161b8325
Port to Thunderbird: Remove SearchEngine.wrappedJSObject. r=bustage-fix