200401 - Bookmarks are not saved

Status: RESOLVED DUPLICATE of bug 200498

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Matthew Good]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030402 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030402 Phoenix/0.5

I just began with a new installation of Phoenix, no previously existing profile
and I deleted several of the bookmarks from the list and when I exited and
restarted Phoenix the old bookmarks were still there.  The bookmarks file is not
read only as someone had encountered in a Linux build, Phoenix seems to simply
not save the bookmarks when exiting as it should.  

Reproducible: Always

Steps to Reproduce:
1. Install Phoenix
2. Start Phoenix
3. Modify bookmarks
4. Exit Phoenix

Actual Results:  
Bookmarks were not saved.

Expected Results:  
Save the bookmarks file.

Comment 1

[noririty]

Confirming.
Adding dataloss to keyword.
->P2

-> Target Milestone0.6?

Comment 2

[Pierre Chanial]

sure. Bookmarks are badly broken.

Comment 3

[Sébastien Delahaye]

Related to bug 199328 (if not dupe)

Comment 4

[Patrick]

Imho not a blocker but a dupe of 199328?

Comment 5

[noririty]

Build ID 20030326 (Bug 199328) can save bookmarks.
I open this as independent phenomenon.

Please mark as dup. if you disagree with this comment.

Comment 6

[Sébastien Delahaye]

*** Bug 200518 has been marked as a duplicate of this bug. ***

Comment 7

[Corwin K. Watts]

I think that the OS affected part of the bug needs to be changed. I'm using
Windows 98 and having the same problem.

Comment 8

[Matthew Good]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4a) Gecko/20030403 Phoenix/0.5

Today I downloaded the new build and tested the "Export" option in the Bookmark
Manager to see whether I could save bookmarks at all and it didn't work.  So, it
seems the bug is in the code to save the bookmarks and is not directly related
to exiting the program.

Comment 9

[Matthew Good]

Ok, I went back and tested some older builds and 20030402 is the first one that
seems to have this problem; 20030401 seems to save to bookmarks just fine.  

I checked bonsai to see who made changes around that time and it seems that the
only updates to the bookmarks code around that time is this on 04/02/2003 05:11
[e-mail] checked in changes to Makefile.in, nsBookmarksService.cpp,
and nsBookmarksService.h : "Fix for bug 191783. Convert bookmark implemenation
to use nsIFile instead of nsFileSpec. patch by bsmedberg, r=varga, sr=alecf"

I'm adding the author of this patch (bsmedberg) to the CC list, hopefully he can
review his changes to find the source of this problem.

I'm not sure, should I add varga and alecf to the CC list on this bug as well or
not?

Comment 10

[noririty]

Reproduced with Mozilla-trunk.

-> OS: All
-> Browser
-> Bookmarks
Removing Phoenix0.6 from target.

Comment 11

[Andrew Schultz]

worksforme with linux trunk 2003040305.
noririty: what Mozilla build did you test?

Comment 12

[noririty]

Andrew:
Tested and confirmed:
2003040209/Win32
2003040308/Win32

Doesn't occur with *nix?
Can anyone confirm this?

Comment 13

[Patrick]

wfm on Linux Mandrake 9.1 and Phoenix 2003040308.
did NOT wfm on xp pro sp1 and Phoenix 2003040208.

Anyone on Mac? Otherwise OS should go back to the windows world [even though
there's no entry "Windows all"]

Changing procuct to PHOENIX as this doesn't seem present in my regular Mozilla
nightlies

Comment 14

[KENZ (Kenji Irie)]

Patrick:
I reproduced this bug on my mozilla 2003-04-03-08-trunk/win98.
This is not only phoenix bug.

Comment 15

[noririty]

I can also reproduce this bug on Mozilla 2003-04-03-08-trunk/WindowsXP.

Please make sure that you need to create new profile before confirmation.

-> OS: Windows
-> Browser (Mozilla)
-> Bookmarks

Comment 16

[Benjamin Smedberg]

I introduced this problem with bug 191783, and this is a dup the same as bug
200498, which ought to be fixed soon (today or tomorrow).

*** This bug has been marked as a duplicate of 200498 ***