2005158 - browser_ext_popup_corners fails when run standalone

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Dale Harvey (:daleharvey)]

While working on https://bugzilla.mozilla.org/show_bug.cgi?id=1988726 I was running into failures in this test, disabling the feature still caused the test to fail in verify mode which was confusing, the test also always failed locally. I could get the test to pass if I run the entire test directory, so this seems to have a dependency on a previous test which makes it very confusing to diagnose what is causing it to fail

Comment 2

[Rob Wu [:robwu]]

I looked into the failure. The test expects the extension button to be hidden from the toolbar (moved into the extensions panel on overflow). That does somehow not happen. I modified the test by prepending another extension button, which successfully caused it to move.

However, upon taking a closer look, we don't need that part of the test any more. It was originally added as a regression test for bug 1786587, to verify that the panel is positioned correctly when the button was inside the overflow menu. We now render overflown extension buttons inside the Extensions Panel (by bug 1797155), and the test has since been morphed into one where the button starts inside the Extensions Panel instead of the overflow menu (diff that dropped the original logic), which means that the test has moved far from what it was originally supposed to test. The only potentially remaining scenario that the test could be covering is to verify the overflow behavior (=button moves elsewhere) when the buttons do not fit in the window, but that scenario is already covered more explicitly in browser_unified_extensions_overflowable_toolbar.js.

I'll attach a patch that drops the part of the test.

Comment 3

[Rob Wu [:robwu]]

Attachment: Bug 2005158 - Remove obsolete test from browser_ext_popup_corners.js

See https://bugzilla.mozilla.org/show_bug.cgi?id=2005158#c2

Comment 4

[Intermittent Failures Robot]

7 failures were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• mozilla-central: 1

Table

	no_variant
linux2404-x86_64/debug	1
linux2404-x86_64/opt	1
linux2404-x86_64/tsan	1
windows11-x86/opt	1
windows11-x86_64/ccov	1
windows11-x86_64/debug	1
windows11-x86_64/opt	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=2005158&startday=2025-12-08&endday=2025-12-14&tree=all

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a83174d40498
https://hg.mozilla.org/integration/autoland/rev/48fe3509bae9
Remove obsolete test from browser_ext_popup_corners.js r=willdurand

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/48fe3509bae9