Closed Bug 2007397 Opened 11 months ago Closed 6 months ago

Add test coverage to ensure removed search engines are no longer displayed in the default engines dropdown

Categories

(Firefox :: Settings UI, task, P2)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: scunnane, Assigned: scunnane)

References

Details

(Whiteboard: [sng][srd-followups])

Attachments

(2 external files)

The patch for Bug 2007059 fixed an issue where removed search engines were still being displayed in the default engines dropdown. Due to limited timing (holidays and working on another SRD card), I wasn't able to include a test alongside the bug fix.

An extra task can probably be added to browser/components/preferences/tests/browser_searchDefaultEngine.js.

Summary: Add test coverage to ensure removed search engines are still displayed in the default engines dropdown → Add test coverage to ensure removed search engines are no longer displayed in the default engines dropdown
Whiteboard: [recomp-support] → [sng][srd-followups]
Pushed by scunnane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d1ededad4ccc https://hg.mozilla.org/integration/autoland/rev/9971c40ae9ec Add test coverage to ensure removed search engines are no longer displayed in the default engines dropdown. r=Standard8,hjones
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

May I ask you to uplift this change to avoid merge conflicts while uplifting Bug 2037663 - Prepare search tests for the SRD pref flip?

Flags: needinfo?(scunnane)

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Unless uplifted, this patch will cause merge conflicts with ongoing work to be able to set the settings redesign pref to true by default.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: n/a
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is a patch of limited scope that has automated test coverage and has been manually verified by reviewers and QA.
  • String changes made/needed?: n/a
  • Is Android affected?: no
Attachment #9588913 - Flags: approval-mozilla-beta?
Flags: needinfo?(scunnane)
Flags: in-testsuite+
Attachment #9588913 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: