2007435 - Adapt tests to handle new HTML color picker behavior (from bug 1629388)

Status: ASSIGNED

(Thunderbird :: Upstream Synchronization, defect)

Description

[Toby Pilling [:tobyp]]

Since the changes in bug 1629388 and related InputPicker refactors landed, several Thunderbird browser tests have started failing.

These failures are not due to regressions in Thunderbird functionality, but rather to test assumptions that no longer hold with the new HTML color picker implementation. In particular:

• The color picker is now modeless and CSS-resolved.
• Color values can differ across theme switches (e.g. light to dark).
• Exact RGB equality is no longer a stable invariant after a theme change.

As a short-term mitigation to green up the tree, affected tests currently disable the new color picker via the dom.forms.html_color_picker.enabled pref (see https://phabricator.services.mozilla.com/D277359). This mirrors the approach taken upstream in mozilla-central for legacy form tests.

The purpose of this bug is to track the actual test adaptations needed to work correctly with the new picker behaviour, so that the pref override can eventually be removed. This includes:

• Updating tests to assert behavior (e.g. “custom color used vs the default”) instead of exact color values where appropriate.
• Adjusting expectations around theme switches.
• Ensuring tests reflect the UI behavior users see in Daily/Nightly builds.

Once these changes are complete, the pref-based workaround can be removed and the tests can exercise the new HTML color picker directly.

Comment 1

[Toby Pilling [:tobyp]]

Attachment: WIP: Bug 2007435 - Update folder color tests for new HTML color picker behavior. r=#thunderbird-reviewers

Comment 2

[Toby Pilling [:tobyp]]

Watch bug 2007518 to see how m-c handles these changes